[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2eq7nuv2zddslzpfui5plh6b7lhvqwrv3ik5wprsatu4ubd7hj@llyibugzcrwm>
Date: Sun, 17 Aug 2025 13:28:26 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <brgl@...ev.pl>, Jonathan Corbet <corbet@....net>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Arnd Bergmann <arnd@...nel.org>,
Hans de Goede <hansg@...nel.org>, linux-gpio@...r.kernel.org, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Documentation: gpio: add documentation about using
software nodes
Hi Randy,
On Sat, Aug 16, 2025 at 04:17:32PM -0700, Randy Dunlap wrote:
>
>
> On 8/16/25 3:21 PM, Randy Dunlap wrote:
> >
> >
> > On 8/16/25 3:08 PM, Randy Dunlap wrote:
> >> Hi,
> >>
> >> On 8/15/25 10:30 AM, Dmitry Torokhov wrote:
> >>> Introduce documentation regarding use of software nodes to describe
> >>> GPIOs on legacy boards that have not been converted to device tree.
> >>>
> >>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> >>> ---
> >>>
> >>> v2: Addressed Randy's comments.
> >>>
> >>> Documentation/driver-api/gpio/board.rst | 65 ++++
> >>> Documentation/driver-api/gpio/index.rst | 1 +
> >>> .../driver-api/gpio/legacy-boards.rst | 298 ++++++++++++++++++
> >>> 3 files changed, 364 insertions(+)
>
> Hi Dmitry,
>
> There are a few build errors with the example code. It's OK to leave that
> as an exercise for the reader. :)
>
> There are a few missing header files, but the biggest build warning/error
> is a Section mismatch:
> WARNING: modpost: gpio-swnodes: section mismatch in reference: myboard_exit+0x1f (section: .exit.text) -> myboard_swnodes (section: .init.rodata)
>
> so myboard_swnodes should not be marked as __initconst.
Ah, yes, indeed, I'll drop the annotation. Thank you for all the
reviews.
--
Dmitry
Powered by blists - more mailing lists