linux-kernel - Re: [PATCH 2/2] ASoC: dt-bindings: ti,pcm1754: add binding documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <826f4f63-1c2d-4598-9d21-1e905d9b0d89@kernel.org>
Date: Mon, 18 Aug 2025 15:35:47 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Stefan Kerkmann <s.kerkmann@...gutronix.de>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>, Alvin Šipraga
 <alsi@...g-olufsen.dk>
Cc: linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH 2/2] ASoC: dt-bindings: ti,pcm1754: add binding
 documentation

On 18/08/2025 15:01, Stefan Kerkmann wrote:
> The Texas Instruments PCM1754 is a simple stereo DAC without any digital
> management interface but soft mute, PCM input format and 44.1 kHz
> digital de-emphasis can be configured via strapping pins. Only soft mute
> and PCM input format selection is currently exposed via optional GPIOs
> in the driver.
> 
> Signed-off-by: Stefan Kerkmann <s.kerkmann@...gutronix.de>
> ---
>  .../devicetree/bindings/sound/ti,pcm1754.yaml      | 54 ++++++++++++++++++++++

Missing rest of patches and user of that. Maybe these are in 1/2? But
then this is misordered, see submitting patches in DT.


>  1 file changed, 54 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/ti,pcm1754.yaml b/Documentation/devicetree/bindings/sound/ti,pcm1754.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..924386092a60e6637a1134f174511e7e61b16839
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/ti,pcm1754.yaml
> @@ -0,0 +1,54 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/ti,pcm1754.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments PCM1754 Stereo DAC
> +
> +description: |

Drop |

> +  The PCM1754 is a simple stereo DAC that is controlled via hardware gpios.
> +
> +maintainers:
> +  - Stefan Kerkmann <s.kerkmann@...gutronix.de>
> +
> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,pcm1754
> +
> +  VCC-supply: true

Lowercase, vcc-supply

> +
> +  '#sound-dai-cells':
> +    const: 0
> +
> +  format-gpios:
> +    maxItems: 1
> +    description:
> +      GPIO used to select the PCM format
> +
> +  mute-gpios:
> +    maxItems: 1
> +    description:
> +      GPIO used to mute all outputs
> +
> +required:
> +  - "#sound-dai-cells"

Keep consistent quotes

> +  - compatible

compatible is always the first. Don't use different ordering here.

Missing supply.

> +
> +additionalProperties: false
> +


Best regards,
Krzysztof