linux-kernel - Re: [PATCH] ubifs: vmalloc(array_size()) -> vmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFLxGvy0c=Ja6WBmpmCmqKMpe-AX5n3xMpuFiKz3JWOanrLqvA@mail.gmail.com>
Date: Mon, 18 Aug 2025 15:49:07 +0200
From: Richard Weinberger <richard.weinberger@...il.com>
To: Qianfeng Rong <rongqianfeng@...o.com>
Cc: Richard Weinberger <richard@....at>, Zhihao Cheng <chengzhihao1@...wei.com>, 
	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ubifs: vmalloc(array_size()) -> vmalloc_array()

On Sun, Aug 17, 2025 at 10:12 AM Qianfeng Rong <rongqianfeng@...o.com> wrote:
>
> Remove array_size() calls and replace vmalloc() with vmalloc_array() in
> ubifs_create_dflt_lpt()/lpt_init_rd()/lpt_init_wr(). vmalloc_array() is
> optimized better, resulting in less instructions being used [1].
>
> [1]: https://lore.kernel.org/lkml/abc66ec5-85a4-47e1-9759-2f60ab111971@vivo.com/
>
> Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>
> ---
>  fs/ubifs/lpt.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Makes sense. Do you want me to carry this through the ubifs tree or do you have
a distinct tree with all your vmalloc_array() patches?

-- 
Thanks,
//richard