linux-kernel - Re: [PATCH net v4] phy: mscc: Fix timestamping for vsc8584

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250818140104.n43xkl7dunfml6mt@skbuf>
Date: Mon, 18 Aug 2025 17:01:04 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: Horatiu Vultur <horatiu.vultur@...rochip.com>, andrew@...n.ch,
	hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	richardcochran@...il.com, rmk+kernel@...linux.org.uk,
	rosenp@...il.com, christophe.jaillet@...adoo.fr,
	viro@...iv.linux.org.uk, quentin.schulz@...tlin.com,
	atenart@...nel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v4] phy: mscc: Fix timestamping for vsc8584

On Mon, Aug 18, 2025 at 02:53:22PM +0100, Vadim Fedorenko wrote:
> On 18/08/2025 14:21, Vladimir Oltean wrote:
> > On Mon, Aug 18, 2025 at 10:10:29AM +0200, Horatiu Vultur wrote:
> > > diff --git a/drivers/net/phy/mscc/mscc_main.c b/drivers/net/phy/mscc/mscc_main.c
> > > index 37e3e931a8e53..800da302ae632 100644
> > > --- a/drivers/net/phy/mscc/mscc_main.c
> > > +++ b/drivers/net/phy/mscc/mscc_main.c
> > > @@ -2368,6 +2368,13 @@ static int vsc85xx_probe(struct phy_device *phydev)
> > >   	return vsc85xx_dt_led_modes_get(phydev, default_mode);
> > >   }
> > > +static void vsc85xx_remove(struct phy_device *phydev)
> > > +{
> > > +	struct vsc8531_private *priv = phydev->priv;
> > > +
> > > +	skb_queue_purge(&priv->rx_skbs_list);
> > > +}
> > 
> > Have you tested this patch with an unbind/bind cycle? Haven't you found
> > that a call to ptp_clock_unregister() is also missing?
> 
> It was missing before this patch as well, probably needs another patch
> to fix this issue

Sure, separate patch, but the addition I highlighted is pretty obviously
untested.