linux-kernel - Re: [PATCH] x86/CPU/AMD: Ignore invalid reset reason value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250818143126.GHaKM5PsVZPXwr5sPi@fat_crate.local>
Date: Mon, 18 Aug 2025 16:31:26 +0200
From: Borislav Petkov <bp@...en8.de>
To: Sean Christopherson <seanjc@...gle.com>
Cc: Mario Limonciello <mario.limonciello@....com>,
	Yazen Ghannam <yazen.ghannam@....com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, Libing He <libhe@...hat.com>,
	David Arcari <darcari@...hat.com>
Subject: Re: [PATCH] x86/CPU/AMD: Ignore invalid reset reason value

On Mon, Aug 18, 2025 at 07:24:26AM -0700, Sean Christopherson wrote:
> Most definitely not if the guest owner and host owner are not one and the same.
> The example use case is where the platform owner is running one of _their_ kernels
> in a VM, in which case that kernel probably does want to know why the platform
> reboot.

Except that can you control who uses that feature? If it ends up being used by
a VM stack where the guest owner should not know the reboot reason, you've
lost.

> The same thing that guarantees hardware vendors adhere to specs: the desire to
> get paid.

So you're basically saying all HV vendors return -1 for an unimplemented
register and we should be fine there?

> And QEMU did return an error value, 0xffffffff, a.k.a. PCI Master Abort / PCIe
> Unsupported Request.  I would be amazed if any real world, general purpose VMM
> did anything else for an MMIO access to an unknown/unsupported range.

Ok, I guess we will know soon enough. :-)

> Huh?  Handle a read of all 0xffs as proposed in this patch, and this is unnecessary.

I don't trust that all HVs will DTRT. But ok, I'll take your word for it. We
can run with this and we'll know soon enough whether fishing out -1 is good
enough. And then we'll have more fun.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette