linux-kernel - Re: [PATCH] ARM: stacktrace: include asm/sections.h in asm/stacktrace.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdacTwnFxgfEDE_eSd2ZBt4pau69RM_z9TnS4eJh-tvjgA@mail.gmail.com>
Date: Mon, 18 Aug 2025 17:27:11 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Russell King <linux@...linux.org.uk>, Li Huafei <lihuafei1@...wei.com>, 
	"Russell King (Oracle)" <rmk+kernel@...linux.org.uk>, Arnd Bergmann <arnd@...db.de>, Kees Cook <kees@...nel.org>, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: stacktrace: include asm/sections.h in asm/stacktrace.h

On Thu, Aug 7, 2025 at 9:19 AM Arnd Bergmann <arnd@...nel.org> wrote:

> From: Arnd Bergmann <arnd@...db.de>
>
> The recent kstack erase changes appear to have uncovered an existing
> issue with a missing header inclusion:
>
> In file included from drivers/misc/lkdtm/kstack_erase.c:12:
> In file included from include/linux/kstack_erase.h:16:
> arch/arm/include/asm/stacktrace.h:48:21: error: call to undeclared function 'in_entry_text'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>    48 |                 frame->ex_frame = in_entry_text(frame->pc);
>       |                                   ^
>
> Include asm/sections.h here so the compiler can see the in_entry_text()
> declaration.
>
> Fixes: 752ec621ef5c ("ARM: 9234/1: stacktrace: Avoid duplicate saving of exception PC value")
> Cc: Kees Cook <kees@...nel.org>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Looks like the correct fix to me:

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij