linux-kernel - Re: [PATCH 11/13] arm64: dts: renesas: rzt2h/rzn2h: Enable eMMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUeLewbDu-pge0ee0+AKzicKuS7fzce7d0pNc20h6CoGQ@mail.gmail.com>
Date: Mon, 18 Aug 2025 18:01:37 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Prabhakar <prabhakar.csengg@...il.com>
Cc: Magnus Damm <magnus.damm@...il.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	linux-renesas-soc@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH 11/13] arm64: dts: renesas: rzt2h/rzn2h: Enable eMMC

Hi Prabhakar,

On Tue, 12 Aug 2025 at 22:03, Prabhakar <prabhakar.csengg@...il.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
>
> Enable eMMC on RZ/T2H and RZ/N2H EVKs. As SDHI0 can be connected to
> either eMMC0/SD0 `SD0_EMMC` macro is added.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r9a09g087m44-rzn2h-evk.dts
> +++ b/arch/arm64/boot/dts/renesas/r9a09g087m44-rzn2h-evk.dts
> @@ -10,6 +10,15 @@
>  #include <dt-bindings/gpio/gpio.h>
>
>  #include "r9a09g087m44.dtsi"
> +
> +/*
> + * SD0 can be connected to either eMMC (U33) or SD card slot CN21
> + * Lets by default enable the eMMC, note we need the below SW settings
> + * for eMMC.
> + * DSW5[1] = ON; DSW5[2] = ON
> + */

Both SD0 and eMMC also need DSW17[5] = OFF; DSW17[6] = ON.

> +#define SD0_EMMC       1
> +
>  #include "rzt2h-n2h-evk-common.dtsi"
>
>  /*

> --- a/arch/arm64/boot/dts/renesas/rzt2h-n2h-evk-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzt2h-n2h-evk-common.dtsi

> @@ -44,6 +63,34 @@ sci0_pins: sci0-pins {
>                 pinmux = <RZT2H_PORT_PINMUX(27, 4, 0x14)>,
>                          <RZT2H_PORT_PINMUX(27, 5, 0x14)>;
>         };
> +
> +#if SD0_EMMC
> +       sdhi0-emmc-iovs-hog {
> +               gpio-hog;
> +               gpios = <RZT2H_GPIO(2, 6) GPIO_ACTIVE_HIGH>;
> +               output-high;
> +               line-name = "SD0_IOVS";
> +       };
> +#endif
> +
> +       sdhi0_emmc_pins: sd0-emmc-group {
> +               sd0-emmc-data-pins {

No need for repeated sd0-emmc-prefixes in the subnodes.


> +                       pinmux = <RZT2H_PORT_PINMUX(12, 2, 0x29)>, /* SD0_DATA0 */
> +                                <RZT2H_PORT_PINMUX(12, 3, 0x29)>, /* SD0_DATA1 */
> +                                <RZT2H_PORT_PINMUX(12, 4, 0x29)>, /* SD0_DATA2 */
> +                                <RZT2H_PORT_PINMUX(12, 5, 0x29)>, /* SD0_DATA3 */
> +                                <RZT2H_PORT_PINMUX(12, 6, 0x29)>, /* SD0_DATA4 */
> +                                <RZT2H_PORT_PINMUX(12, 7, 0x29)>, /* SD0_DATA5 */
> +                                <RZT2H_PORT_PINMUX(13, 0, 0x29)>, /* SD0_DATA6 */
> +                                <RZT2H_PORT_PINMUX(13, 1, 0x29)>; /* SD0_DATA7 */
> +               };
> +
> +               sd0-emmc-ctrl-pins {
> +                       pinmux = <RZT2H_PORT_PINMUX(12, 0, 0x29)>, /* SD0_CLK */
> +                                <RZT2H_PORT_PINMUX(12, 1, 0x29)>, /* SD0_CMD */
> +                                <RZT2H_PORT_PINMUX(13, 2, 0x29)>; /* SD0_RST# */
> +               };
> +       };
>  };

The rest LGTM.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds