linux-kernel - Re: [PATCH] ACPI: APEI: EINJ: fix potential NULL dereference in __einj_error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0iTc+F8AX_sOY_79A9AeTJMe+QiCdK9ZTSwJ8fi4djB=Q@mail.gmail.com>
Date: Mon, 18 Aug 2025 18:11:23 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Hanjun Guo <guohanjun@...wei.com>, tony.luck@...el.com, 
	Charles Han <hanchunchao@...pur.com>
Cc: bp@...en8.de, mchehab@...nel.org, xueshuai@...ux.alibaba.com, 
	lenb@...nel.org, ira.weiny@...el.com, zaidal@...amperecomputing.com, 
	Jonathan.Cameron@...wei.com, colin.i.king@...il.com, dan.carpenter@...aro.org, 
	dan.j.williams@...el.com, sudeep.holla@....com, linux-acpi@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI: APEI: EINJ: fix potential NULL dereference in __einj_error_inject

On Mon, Aug 18, 2025 at 6:07 PM Hanjun Guo <guohanjun@...wei.com> wrote:
>
> On 2025/8/15 10:42, Charles Han wrote:
> > The __einj_error_inject() function allocates memory via kmalloc()
> > without checking for allocation failure, which could lead to a
> > NULL pointer dereference.
> >
> > Return -ENOMEM in case allocation fails.
> >
> > Fixes: b47610296d17 ("ACPI: APEI: EINJ: Enable EINJv2 error injections")
> > Signed-off-by: Charles Han <hanchunchao@...pur.com>
> > ---
> >   drivers/acpi/apei/einj-core.c | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/acpi/apei/einj-core.c b/drivers/acpi/apei/einj-core.c
> > index bf8dc92a373a..93a3ae1325e5 100644
> > --- a/drivers/acpi/apei/einj-core.c
> > +++ b/drivers/acpi/apei/einj-core.c
> > @@ -540,6 +540,9 @@ static int __einj_error_inject(u32 type, u32 flags, u64 param1, u64 param2,
> >               struct set_error_type_with_address *v5param;
> >
> >               v5param = kmalloc(v5param_size, GFP_KERNEL);
> > +             if (!v5param)
> > +                     return -ENOMEM;
> > +
> >               memcpy_fromio(v5param, einj_param, v5param_size);
> >               v5param->type = type;
> >               if (type & ACPI5_VENDOR_BIT) {
>
> Reviewed-by: Hanjun Guo <guohanjun@...wei.com>

Applied as 6.17-rc material, thanks!