linux-kernel - RE: [PATCH 110/114] clk: visconti: pll: convert from round_rate() to determine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <TY7PR01MB14818C45588C929ECBFD51F5A9231A@TY7PR01MB14818.jpnprd01.prod.outlook.com>
Date: Mon, 18 Aug 2025 00:48:10 +0000
From: <nobuhiro1.iwamatsu@...hiba.co.jp>
To: <bmasney@...hat.com>, <mturquette@...libre.com>, <sboyd@...nel.org>,
        <sudeep.holla@....com>, <cristian.marussi@....com>,
        <unicorn_wang@...look.com>, <inochiama@...il.com>,
        <nicolas.ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
        <claudiu.beznea@...on.dev>, <paul@...pouillou.net>,
        <keguang.zhang@...il.com>, <sugaya.taichi@...ionext.com>,
        <orito.takao@...ionext.com>, <shawnguo@...nel.org>,
        <s.hauer@...gutronix.de>, <kernel@...gutronix.de>,
        <festevam@...il.com>, <ychuang3@...oton.com>, <schung@...oton.com>,
        <vz@...ia.com>, <piotr.wojtaszczyk@...esys.com>,
        <paul.walmsley@...ive.com>, <samuel.holland@...ive.com>,
        <dlan@...too.org>, <Steen.Hegelund@...rochip.com>,
        <daniel.machon@...rochip.com>, <UNGLinuxDriver@...rochip.com>,
        <orsonzhai@...il.com>, <baolin.wang@...ux.alibaba.com>,
        <zhang.lyra@...il.com>, <mcoquelin.stm32@...il.com>,
        <alexandre.torgue@...s.st.com>, <michal.simek@....com>,
        <mripard@...nel.org>, <afaerber@...e.de>, <mani@...nel.org>,
        <sven@...nel.org>, <j@...nau.net>, <alyssa@...enzweig.io>,
        <neal@...pa.dev>, <Eugeniy.Paltsev@...opsys.com>, <rjui@...adcom.com>,
        <sbranden@...adcom.com>, <bcm-kernel-feedback-list@...adcom.com>,
        <jcmvbkbc@...il.com>, <matthias.bgg@...il.com>,
        <angelogioacchino.delregno@...labora.com>, <daniel@...ngy.jp>,
        <romain.perier@...il.com>, <andrew@...n.ch>,
        <gregory.clement@...tlin.com>, <sebastian.hesselbarth@...il.com>,
        <andersson@...nel.org>, <geert+renesas@...der.be>, <heiko@...ech.de>,
        <andrea.porta@...e.com>, <krzk@...nel.org>, <s.nawrocki@...sung.com>,
        <cw00.choi@...sung.com>, <alim.akhtar@...sung.com>,
        <qinjian@...lus1.com>, <vireshk@...nel.org>, <ulf.hansson@...aro.org>,
        <luca.ceresoli@...tlin.com>, <alexander.helms.jy@...esas.com>,
        <linus.walleij@...aro.org>, <liviu.dudau@....com>,
        <lpieralisi@...nel.org>
CC: <linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <arm-scmi@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <sophgo@...ts.linux.dev>, <linux-mips@...r.kernel.org>,
        <imx@...ts.linux.dev>, <linux-riscv@...ts.infradead.org>,
        <spacemit@...ts.linux.dev>, <linux-stm32@...md-mailman.stormreply.com>,
        <patches@...nsource.cirrus.com>, <linux-actions@...ts.infradead.org>,
        <asahi@...ts.linux.dev>, <linux-mediatek@...ts.infradead.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-renesas-soc@...r.kernel.org>,
        <linux-rockchip@...ts.infradead.org>,
        <linux-samsung-soc@...r.kernel.org>, <soc@...ts.linux.dev>
Subject: RE: [PATCH 110/114] clk: visconti: pll: convert from round_rate() to
 determine_rate()

> Subject: [PATCH 110/114] clk: visconti: pll: convert from round_rate() to
> determine_rate()
> 
> From: Brian Masney <bmasney@...hat.com>
> 
> The round_rate() clk ops is deprecated, so migrate this driver from
> round_rate() to determine_rate() using the Coccinelle semantic patch on the
> cover letter of this series.
> 
> Signed-off-by: Brian Masney <bmasney@...hat.com>

Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@...hiba.co.jp>

> ---
>  drivers/clk/visconti/pll.c | 17 +++++++++++------
>  1 file changed, 11 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/clk/visconti/pll.c b/drivers/clk/visconti/pll.c index
> 8ca1bad61864204027b7aff9020f1cb9e7d198d3..681721d8503203de9ac49ac32
> 07e121bb5bf2163 100644
> --- a/drivers/clk/visconti/pll.c
> +++ b/drivers/clk/visconti/pll.c
> @@ -100,8 +100,8 @@ static unsigned long
> visconti_get_pll_rate_from_data(struct visconti_pll *pll,
>  	return rate_table[0].rate;
>  }
> 
> -static long visconti_pll_round_rate(struct clk_hw *hw,
> -				    unsigned long rate, unsigned long *prate)
> +static int visconti_pll_determine_rate(struct clk_hw *hw,
> +				       struct clk_rate_request *req)
>  {
>  	struct visconti_pll *pll = to_visconti_pll(hw);
>  	const struct visconti_pll_rate_table *rate_table = pll->rate_table; @@
> -109,11 +109,16 @@ static long visconti_pll_round_rate(struct clk_hw *hw,
> 
>  	/* Assuming rate_table is in descending order */
>  	for (i = 0; i < pll->rate_count; i++)
> -		if (rate >= rate_table[i].rate)
> -			return rate_table[i].rate;
> +		if (req->rate >= rate_table[i].rate) {
> +			req->rate = rate_table[i].rate;
> +
> +			return 0;
> +		}
> 
>  	/* return minimum supported value */
> -	return rate_table[i - 1].rate;
> +	req->rate = rate_table[i - 1].rate;
> +
> +	return 0;
>  }
> 
>  static unsigned long visconti_pll_recalc_rate(struct clk_hw *hw, @@ -232,7
> +237,7 @@ static const struct clk_ops visconti_pll_ops = {
>  	.enable = visconti_pll_enable,
>  	.disable = visconti_pll_disable,
>  	.is_enabled = visconti_pll_is_enabled,
> -	.round_rate = visconti_pll_round_rate,
> +	.determine_rate = visconti_pll_determine_rate,
>  	.recalc_rate = visconti_pll_recalc_rate,
>  	.set_rate = visconti_pll_set_rate,
>  };
> 
> --
> 2.50.1


Best regards,
  Nobuhiro