linux-kernel - Re: [PATCH v5 1/5] dt-bindings: iio: mcp9600: Add microchip,mcp9601 and add constraints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250818-platinum-elude-894088c738d2@spud>
Date: Mon, 18 Aug 2025 18:20:09 +0100
From: Conor Dooley <conor@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Ben Collins <bcollins@...nel.org>, Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Andrew Hepp <andrew.hepp@...pp.dev>,
	Ben Collins <bcollins@...ter.com>, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/5] dt-bindings: iio: mcp9600: Add microchip,mcp9601
 and add constraints

On Mon, Aug 18, 2025 at 08:28:30AM +0200, Krzysztof Kozlowski wrote:
> On 18/08/2025 05:59, Ben Collins wrote:
> >    interrupts:
> >      minItems: 1
> > -    maxItems: 6
> > +    maxItems: 4
> 
> Why?
> I did not find explanation of this in commit msg.

It's also not correct, since the outermost constraint remains 6 after
the patch, so the if/else should reduce the constraints, rather than
increase it as is done here.

> 
> >  
> >    interrupt-names:
> >      minItems: 1
> > -    maxItems: 6
> >      items:
> > -      enum:
> > -        - open-circuit
> > -        - short-circuit
> > -        - alert1
> > -        - alert2
> > -        - alert3
> > -        - alert4
> > +      - const: alert1
> > +      - const: alert2
> > +      - const: alert3
> > +      - const: alert4
> 
> Neither this and it is ABI break. ABI breaking needs clear reasoning why
> and some evaluation of impact on users.

I think it should be a standalone patch too, since it is a fix for the
existing mcp9600 device rather than something for the mcp9601 device
that is being added by this patch...
> 
> 
> >  
> >    thermocouple-type:
> >      $ref: /schemas/types.yaml#/definitions/uint32
> > +    default: 3

As is this, which is codifying the existing restriction rather than
being something new as 0x03 is what THERMOCOUPLE_TYPE_K is defined to
be.

> >      description:
> >        Type of thermocouple (THERMOCOUPLE_TYPE_K if omitted).
> >        Use defines in dt-bindings/iio/temperature/thermocouple.h.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)