[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250818-departure-gloss-b99cacb9401e@spud>
Date: Mon, 18 Aug 2025 18:38:24 +0100
From: Conor Dooley <conor@...nel.org>
To: Aleksander Jan Bajkowski <olek2@...pl>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
tsbogend@...ha.franken.de, john@...ozen.org,
devicetree@...r.kernel.org, linux-mips@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: mips: lantiq: Document Lantiq Xway
GPTU
On Sat, Aug 16, 2025 at 03:16:22PM +0200, Aleksander Jan Bajkowski wrote:
> The Lantiq SoC has six built-in 16-bit general purpose timers (GPTU).
>
> Signed-off-by: Aleksander Jan Bajkowski <olek2@...pl>
> ---
> .../mips/lantiq/lantiq,gptu-xway.yaml | 67 +++++++++++++++++++
> 1 file changed, 67 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yaml
>
> diff --git a/Documentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yaml b/Documentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yaml
> new file mode 100644
> index 000000000000..fcbcd98def46
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yaml
> @@ -0,0 +1,67 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mips/lantiq/lantiq,gptu-xway.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Lantiq Xway SoC series General Purpose Timer Unit (GPTU)
> +
> +maintainers:
> + - Aleksander Jan Bajkowski <olek2@...pl>
> +
> +description:
> + The Lantiq SoC has six built-in 16-bit general purpose timers. The voice
> + firmware needs these timers as a reference.
> +
> +properties:
> + $nodename:
> + pattern: "^gptu@[0-9a-f]+$"
This is a timer, why are you not using "timer" as the prefix?
Otherwise, this looks okay to me other than...
> +
> + compatible:
> + items:
> + - enum:
> + - lantiq,ase-gptu
> + - lantiq,danube-gptu
> + - lantiq,xrx100-gptu
> + - lantiq,xrx200-gptu
> + - const: lantiq,gptu-xway
..the fact that my OCD hates how the fallback inverts the position of
gptu in the compatible!
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists