linux-kernel - Re: [PATCH 2/2] arm64: dts: rockchip: Fix Bluetooth interrupts flag on Neardi LBA3368

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5593866a-29b2-431b-891b-c15cb2da8361@gmail.com>
Date: Mon, 18 Aug 2025 20:24:16 +0200
From: Alex Bee <knaerzche@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
 Hsun Lai <i@...insx.cn>, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Cc: stable+noautosel@...nel.org
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Fix Bluetooth interrupts flag
 on Neardi LBA3368


Am 18.08.25 um 11:04 schrieb Krzysztof Kozlowski:
> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
> These are simple defines so they could be used in DTS but they will not
> have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE.
>
> Correct the interrupt flags, assuming the author of the code wanted same
> logical behavior behind the name "ACTIVE_xxx", this is:
>    ACTIVE_HIGH  => IRQ_TYPE_LEVEL_HIGH
>
> Fixes: 7b4a8097e58b ("arm64: dts: rockchip: Add Neardi LBA3368 board")
> Cc: <stable+noautosel@...nel.org> # Needs testing, because actual level is just a guess
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>
> ---
>
> Please kindly test... Not cc-ing stable on purpose, because this might
> have impact, so needs actual testing.

Tested-By: Alex Bee <knaerzche@...il.com>

Thanks,

Alex

> ---
>   arch/arm64/boot/dts/rockchip/rk3368-lba3368.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368-lba3368.dts b/arch/arm64/boot/dts/rockchip/rk3368-lba3368.dts
> index b99bb0a5f900..b9801a691b48 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368-lba3368.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3368-lba3368.dts
> @@ -609,7 +609,7 @@ &uart0 {
>   
>   	bluetooth {
>   		compatible = "brcm,bcm4345c5";
> -		interrupts-extended = <&gpio3 RK_PA7 GPIO_ACTIVE_HIGH>;
> +		interrupts-extended = <&gpio3 RK_PA7 IRQ_TYPE_LEVEL_HIGH>;
>   		interrupt-names = "host-wakeup";
>   		clocks = <&rk808 RK808_CLKOUT1>;
>   		clock-names = "lpo";