linux-kernel - Re: [PATCH v3 1/4] iio: adc: adi-axi-adc: add axi_adc_num_lanes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250818192641.61f9af06@jic23-huawei>
Date: Mon, 18 Aug 2025 19:26:41 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Ioana Risteiu <Ioana.Risteiu@...log.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich
 <Michael.Hennerich@...log.com>, David Lechner <dlechner@...libre.com>, Nuno
 Sá <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Ramona Nechita
 <ramona.nechita@...log.com>, <linux-iio@...r.kernel.org>,
 <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/4] iio: adc: adi-axi-adc: add axi_adc_num_lanes_set

On Mon, 18 Aug 2025 16:12:47 +0300
Ioana Risteiu <Ioana.Risteiu@...log.com> wrote:

> Add axi_adc_num_lanes_set in the adi_axi_adc_ops structure to support
> setting number of lanes used by AXI ADC.
> 
> Signed-off-by: Ioana Risteiu <Ioana.Risteiu@...log.com>

So far we only have this set for a specific compatible.  Why does it
now make sense to set it for the 'generic' case? Please add something
to the patch description.

Jonathan

> ---
>  drivers/iio/adc/adi-axi-adc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/adc/adi-axi-adc.c b/drivers/iio/adc/adi-axi-adc.c
> index 2d86bb0e08a7..20bb59c24acf 100644
> --- a/drivers/iio/adc/adi-axi-adc.c
> +++ b/drivers/iio/adc/adi-axi-adc.c
> @@ -617,6 +617,7 @@ static const struct iio_backend_ops adi_axi_adc_ops = {
>  	.chan_status = axi_adc_chan_status,
>  	.interface_type_get = axi_adc_interface_type_get,
>  	.oversampling_ratio_set = axi_adc_oversampling_ratio_set,
> +	.num_lanes_set = axi_adc_num_lanes_set,
>  	.debugfs_reg_access = iio_backend_debugfs_ptr(axi_adc_reg_access),
>  	.debugfs_print_chan_status = iio_backend_debugfs_ptr(axi_adc_debugfs_print_chan_status),
>  };