linux-kernel - Re: [PATCH v5 5/5] iio: mcp9600: Add support for IIR filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <afffc91a-d4fa-47d5-bb59-fad879a2ac6d@baylibre.com>
Date: Mon, 18 Aug 2025 13:59:34 -0500
From: David Lechner <dlechner@...libre.com>
To: Jonathan Cameron <jic23@...nel.org>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 5/5] iio: mcp9600: Add support for IIR filter

On 8/18/25 1:47 PM, Ben Collins wrote:
> On Mon, Aug 18, 2025 at 07:15:39PM -0500, Jonathan Cameron wrote:
>> On Sun, 17 Aug 2025 23:59:53 -0400
>> Ben Collins <bcollins@...nel.org> wrote:
>>
>>> From: Ben Collins <bcollins@...ter.com>
>>>
>>> MCP9600 supports an IIR filter with 7 levels. Add IIR attribute
>>> to allow get/set of this value.
>>>
>>> Use a filter_type[none, ema] for enabling the IIR filter.
>> Hi Ben,
>>
>> A few comments inline. You also need to send an additional patch to update
>> the filter_type docs in Documentation/ABI/testing/sysfs-bus-iio
> 
> Hi Jonathan,
> 
> I just sent a v6 because I was getting too many comments on the
> dt-bindings patch.

Actually, folks will be happier if you slow down a bit. General
advice is only submit one revision per week since some people only
have time to review once per week.

If you are really in a hurry, there should still be no more than
one revision per day. Otherwise, it is really hard for reviewers
to keep up.

As it is, the subject of what I presume is v6 still says v5 in the
cover letter and doesn't have a version in the rest of the patches.
And there are still some of the same problems with the devicetree
patch that didn't get addressed. If you slow down a bit and take
a little more care before firing off the next one, it will likely
be better received.

> 
> I'll send a v7 with these changes and anything else that comes up.
>