linux-kernel - Re: [PATCH v5 5/5] iio: mcp9600: Add support for IIR filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025081815-solemn-beaver-b5dce6@boujee-and-buff>
Date: Mon, 18 Aug 2025 15:31:51 -0400
From: Ben Collins <ben.collins@...ux.dev>
To: David Lechner <dlechner@...libre.com>
Cc: Jonathan Cameron <jic23@...nel.org>, 
	Nuno Sá <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 5/5] iio: mcp9600: Add support for IIR filter

On Mon, Aug 18, 2025 at 01:59:34PM -0500, David Lechner wrote:
> On 8/18/25 1:47 PM, Ben Collins wrote:
> > On Mon, Aug 18, 2025 at 07:15:39PM -0500, Jonathan Cameron wrote:
> >> On Sun, 17 Aug 2025 23:59:53 -0400
> >> Ben Collins <bcollins@...nel.org> wrote:
> >>
> >>> From: Ben Collins <bcollins@...ter.com>
> >>>
> >>> MCP9600 supports an IIR filter with 7 levels. Add IIR attribute
> >>> to allow get/set of this value.
> >>>
> >>> Use a filter_type[none, ema] for enabling the IIR filter.
> >> Hi Ben,
> >>
> >> A few comments inline. You also need to send an additional patch to update
> >> the filter_type docs in Documentation/ABI/testing/sysfs-bus-iio
> > 
> > Hi Jonathan,
> > 
> > I just sent a v6 because I was getting too many comments on the
> > dt-bindings patch.
> 
> Actually, folks will be happier if you slow down a bit. General
> advice is only submit one revision per week since some people only
> have time to review once per week.

I appreciate the info. Admittedly, when I was more prolific with kernel
development, the pipline and protocol was much leaner, so I'm not used
to the more recent "norm" quite yet.

Not complaining, just noting. I'll get there.

-- 
 Ben Collins
 https://libjwt.io
 https://github.com/benmcollins
 --
 3EC9 7598 1672 961A 1139  173A 5D5A 57C7 242B 22CF

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)