linux-kernel - Re: [PATCH v7 0/7] Add SEV-SNP CipherTextHiding feature support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51f0c677-1f9f-4059-9166-82fb2ed0ecbb@amd.com>
Date: Mon, 18 Aug 2025 14:38:38 -0500
From: Kim Phillips <kim.phillips@....com>
To: "Kalra, Ashish" <ashish.kalra@....com>, Herbert Xu
	<herbert@...dor.apana.org.au>
CC: <Neeraj.Upadhyay@....com>, <aik@....com>, <akpm@...ux-foundation.org>,
	<ardb@...nel.org>, <arnd@...db.de>, <bp@...en8.de>, <corbet@....net>,
	<dave.hansen@...ux.intel.com>, <davem@...emloft.net>, <hpa@...or.com>,
	<john.allen@....com>, <kvm@...r.kernel.org>, <linux-crypto@...r.kernel.org>,
	<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<michael.roth@....com>, <mingo@...hat.com>, <nikunj@....com>,
	<paulmck@...nel.org>, <pbonzini@...hat.com>, <rostedt@...dmis.org>,
	<seanjc@...gle.com>, <tglx@...utronix.de>, <thomas.lendacky@....com>,
	<x86@...nel.org>
Subject: Re: [PATCH v7 0/7] Add SEV-SNP CipherTextHiding feature support

On 8/18/25 2:16 PM, Kalra, Ashish wrote:
> On 8/16/2025 3:39 AM, Herbert Xu wrote:
>> On Mon, Aug 11, 2025 at 08:30:25PM +0000, Ashish Kalra wrote:
>>> Hi Herbert, can you please merge patches 1-5.
>>>
>>> Paolo/Sean/Herbert, i don't know how do you want handle cross-tree merging
>>> for patches 6 & 7.
>> These patches will be at the base of the cryptodev tree for 6.17
>> so it could be pulled into another tree without any risks.
>>
>> Cheers,
> Thanks Herbert for pulling in patches 1-5.
>
> Paolo, can you please merge patches 6 and 7 into the KVM tree.
Hi Ashish,

I have pending comments on patch 7:

https://lore.kernel.org/kvm/e32a48dc-a8f7-4770-9e2f-1f3721872a63@amd.com/

If still not welcome, can you say why you think:

1. The ciphertext_hiding_asid_nr variable is necessary

2. The isdigit(ciphertext_hiding_asids[0])) check is needed when it's 
immediately followed by kstrtoint which effectively makes the open-coded 
isdigit check  redundant?

3. Why the 'invalid_parameter:' label referenced by only one goto 
statement can't be folded and removed.

Thanks,

Kim