linux-kernel - Re: [PATCH v2] perf drm_pmu: fix fd_dir leaks in for_each_drm_fdinfo_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fXkzoJJvn6h-dbTGvxkO3DEtGUfauTSZOAGPjcQMrFUpg@mail.gmail.com>
Date: Mon, 18 Aug 2025 14:30:10 -0700
From: Ian Rogers <irogers@...gle.com>
To: zhaoguohan@...inos.cn
Cc: peterz@...radead.org, mingo@...hat.com, acme@...nel.org, 
	namhyung@...nel.org, mark.rutland@....com, alexander.shishkin@...ux.intel.com, 
	jolsa@...nel.org, adrian.hunter@...el.com, kan.liang@...ux.intel.com, 
	"open list:PERFORMANCE EVENTS SUBSYSTEM" <linux-perf-users@...r.kernel.org>, 
	"open list:PERFORMANCE EVENTS SUBSYSTEM" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] perf drm_pmu: fix fd_dir leaks in for_each_drm_fdinfo_in_dir()

On Tue, Aug 12, 2025 at 8:35 PM <zhaoguohan@...inos.cn> wrote:
>
> From: GuoHan Zhao <zhaoguohan@...inos.cn>
>
> Fix file descriptor leak when callback function returns error. The
> function was directly returning without closing fdinfo_dir_fd and
> fd_dir when cb() returned non-zero value.
>
> Fixes: 28917cb17f9d ("perf drm_pmu: Add a tool like PMU to expose DRM information")
> Signed-off-by: GuoHan Zhao <zhaoguohan@...inos.cn>

Reviewed-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian

> ---
> V1 -> V2: Added the Fixes tag in commit message
> ---
>  tools/perf/util/drm_pmu.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/drm_pmu.c b/tools/perf/util/drm_pmu.c
> index 988890f37ba7..424a76d1a953 100644
> --- a/tools/perf/util/drm_pmu.c
> +++ b/tools/perf/util/drm_pmu.c
> @@ -458,8 +458,10 @@ static int for_each_drm_fdinfo_in_dir(int (*cb)(void *args, int fdinfo_dir_fd, c
>                 }
>                 ret = cb(args, fdinfo_dir_fd, fd_entry->d_name);
>                 if (ret)
> -                       return ret;
> +                       goto cleanup;
>         }
> +
> +cleanup:
>         if (fdinfo_dir_fd != -1)
>                 close(fdinfo_dir_fd);
>         closedir(fd_dir);
> --
> 2.43.0
>