linux-kernel - Re: [PATCH v3 00/12] man2: document "new" mount API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025-08-18.1755493208-minty-roomy-vessel-moisture-2LjJfF@cyphar.com>
Date: Mon, 18 Aug 2025 15:46:05 +1000
From: Aleksa Sarai <cyphar@...har.com>
To: Askar Safin <safinaskar@...omail.com>
Cc: alx@...nel.org, autofs@...r.kernel.org, brauner@...nel.org, 
	dhowells@...hat.com, g.branden.robinson@...il.com, jack@...e.cz, 
	linux-api@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-man@...r.kernel.org, mtk.manpages@...il.com, raven@...maw.net, 
	viro@...iv.linux.org.uk
Subject: Re: [PATCH v3 00/12] man2: document "new" mount API

On 2025-08-17, Askar Safin <safinaskar@...omail.com> wrote:
> I just sent to fsdevel fix for that RESOLVE_NO_XDEV bug.

Thanks, I've sent some review comments.

> 	if (!(lookup_flags & (LOOKUP_PARENT | LOOKUP_DIRECTORY |
> 			   LOOKUP_OPEN | LOOKUP_CREATE | LOOKUP_AUTOMOUNT)) &&
> 
> We never return -EISDIR in this "if" if we are in non-final component
> thanks to LOOKUP_PARENT here. We fall to finish_automount instead.

Grr, I re-read this conditional a few times and I still misunderstood
what it was doing. My bad.

-- 
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
https://www.cyphar.com/

Download attachment "signature.asc" of type "application/pgp-signature" (266 bytes)