linux-kernel - Re: [PATCH v2 17/24] media: iris: Add support for G/S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae63b3c0-e3cb-b81e-6bf0-13818a5cc42e@quicinc.com>
Date: Mon, 18 Aug 2025 11:41:57 +0530
From: Vikash Garodia <quic_vgarodia@...cinc.com>
To: Dikshita Agarwal <quic_dikshita@...cinc.com>,
        Abhinav Kumar
	<abhinav.kumar@...ux.dev>,
        Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Hans Verkuil
	<hverkuil@...all.nl>,
        Stefan Schmidt <stefan.schmidt@...aro.org>,
        "Vedang
 Nagar" <quic_vnagar@...cinc.com>
CC: <linux-media@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Renjiang Han <quic_renjiang@...cinc.com>,
        Wangao Wang <quic_wangaow@...cinc.com>
Subject: Re: [PATCH v2 17/24] media: iris: Add support for G/S_SELECTION for
 encoder video device


On 8/18/2025 8:55 AM, Dikshita Agarwal wrote:
>>> +int iris_venc_s_selection(struct iris_inst *inst, struct v4l2_selection *s)
>>> +{
>>> +	if (s->type != V4L2_BUF_TYPE_VIDEO_OUTPUT)
>>> +		return -EINVAL;
>>> +
>>> +	switch (s->target) {
>>> +	case V4L2_SEL_TGT_CROP:
>>> +		s->r.left = 0;
>>> +		s->r.top = 0;
>>> +
>>> +		if (s->r.width > inst->fmt_src->fmt.pix_mp.width ||
>>> +		    s->r.height > inst->fmt_src->fmt.pix_mp.height)
>>> +			return -EINVAL;
>>> +
>>> +		inst->crop.left = s->r.left;
>>> +		inst->crop.top = s->r.top;
>>> +		inst->crop.width = s->r.width;
>>> +		inst->crop.height = s->r.height;
>>> +		inst->fmt_dst->fmt.pix_mp.width = inst->crop.width;
>>> +		inst->fmt_dst->fmt.pix_mp.height = inst->crop.height;
>>> +		return iris_venc_s_fmt_output(inst, inst->fmt_dst);
>>> +	default:
>>> +		return -EINVAL;
>>> +	}
>>> +
>>> +	return 0;
>> Why do you need a return here ?
> We actually don't, it should be safe to remove this, will fix.

With that fixed,

Reviewed-by: Vikash Garodia <quic_vgarodia@...cinc.com>