[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <BCD8E43E564BC334+1e45d36f-edc7-4c3c-90c9-7b0f2a52360f@radxa.com>
Date: Mon, 18 Aug 2025 15:57:21 +0900
From: FUKAUMI Naoki <naoki@...xa.com>
To: Chukun Pan <amadeus@....edu.cn>, Heiko Stuebner <heiko@...ech.de>
Cc: Conor Dooley <conor+dt@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>,
linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/3] arm64: dts: rockchip: remove vcc_3v3_pmu regulator
for Radxa E52C
Hi Chukun,
On 8/16/25 17:00, Chukun Pan wrote:
> According to Radxa E52C Schematic V1.2 [1] page 5, vcc_3v3_pmu
> is directly connected to vcc_3v3_s3 via a 0 ohm resistor.
> The vcc_3v3_pmu is not a new regulator, so remove it.
>
> [1] https://dl.radxa.com/e/e52c/hw/radxa_e52c_v1.2_schematic.pdf
>
> Signed-off-by: Chukun Pan <amadeus@....edu.cn>
> ---
> arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> index 1883bd183396..4a3ae95f122f 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> @@ -98,16 +98,6 @@ vcc_1v1_nldo_s3: regulator-1v1 {
> vin-supply = <&vcc_sysin>;
> };
>
> - vcc_3v3_pmu: regulator-3v3-0 {
> - compatible = "regulator-fixed";
> - regulator-name = "vcc_3v3_pmu";
> - regulator-always-on;
> - regulator-boot-on;
> - regulator-min-microvolt = <3300000>;
> - regulator-max-microvolt = <3300000>;
> - vin-supply = <&vcc_3v3_s3>;
> - };
> -
> vcc_3v3_s0: regulator-3v3-1 {
> compatible = "regulator-fixed";
> regulator-name = "vcc_3v3_s0";
> @@ -255,7 +245,7 @@ eeprom@50 {
> reg = <0x50>;
> pagesize = <16>;
> read-only;
> - vcc-supply = <&vcc_3v3_pmu>;
> + vcc-supply = <&vcc_3v3_s3>;
How about the following instead?
@@ -538,7 +538,7 @@ regulator-state-mem {
};
};
- vcc_3v3_s3: dcdc-reg8 {
+ vcc_3v3_pmu: vcc_3v3_s3: dcdc-reg8 {
regulator-name = "vcc_3v3_s3";
regulator-always-on;
regulator-boot-on;
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
> };
> };
>
Powered by blists - more mailing lists