linux-kernel - Re: [PATCH 5/7] media: i2c: dw9719: Update PM last busy time upon close

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aKLYVDDLnD5stpqZ@kekkonen.localdomain>
Date: Mon, 18 Aug 2025 07:37:56 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: git@...tzsch.eu
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
	Daniel Scally <djrscally@...il.com>,
	~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	Val Packett <val@...kett.cool>
Subject: Re: [PATCH 5/7] media: i2c: dw9719: Update PM last busy time upon
 close

Hi André,

Thanks for the patchset.

On Sun, Aug 17, 2025 at 07:09:24PM +0200, André Apitzsch via B4 Relay wrote:
> From: Val Packett <val@...kett.cool>
> 
> Update the close callback to match other similar drivers like dw9768.
> 
> Signed-off-by: Val Packett <val@...kett.cool>
> Signed-off-by: André Apitzsch <git@...tzsch.eu>
> ---
>  drivers/media/i2c/dw9719.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/dw9719.c b/drivers/media/i2c/dw9719.c
> index 61758a9450aee20c9226e879a15eccfced9a3e96..2952d8064899e4ac29f3b1af02692fe8043ccfac 100644
> --- a/drivers/media/i2c/dw9719.c
> +++ b/drivers/media/i2c/dw9719.c
> @@ -284,7 +284,8 @@ static int dw9719_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)
>  
>  static int dw9719_close(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)
>  {
> -	pm_runtime_put(sd->dev);
> +	pm_runtime_mark_last_busy(sd->dev);

Please drop this line; the pm_runtime_mark_last_busy() is nowadays called
by pm_runtime_put_autosuspend() already.

> +	pm_runtime_put_autosuspend(sd->dev);
>  
>  	return 0;
>  }
> 

-- 
Kind regards,

Sakari Ailus