linux-kernel - Re: [PATCHv2 ath-next] wifi: ath10k: add nvmem support for mac address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tt2512nn.fsf@bootlin.com>
Date: Mon, 18 Aug 2025 09:59:08 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Rosen Penev <rosenp@...il.com>
Cc: linux-wireless@...r.kernel.org,  Jeff Johnson <jjohnson@...nel.org>,
  ath10k@...ts.infradead.org (open list:QUALCOMM ATHEROS ATH10K WIRELESS
 DRIVER),  linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCHv2 ath-next] wifi: ath10k: add nvmem support for mac address

Hi Rosen,

On 11/08/2025 at 13:34:51 -07, Rosen Penev <rosenp@...il.com> wrote:

> device_get_mac_address is a generic way to get the MAC address which
> lacks NVMEM support, which tends to be used on embedded platforms.
>
> In case device_get_mac_address fails, try of_get_mac_address_nvmem and
> handle EPROBE_DEFER to wait for the nvmem driver to initialize.
>
> Signed-off-by: Rosen Penev <rosenp@...il.com>
> ---
>  v2: keep device_get_mac_address and use of_get_mac_address_nvmem
>  added Miquel to CC. Maybe he has insight.

LGTM. I guess it is not possible to make this fallback "the default" in
device_get_mac_address()? In this case doing it in your driver seems
fine if it's used on embedded systems with NVMEM cells described to
store MAC addresses.

Cheers,
Miquèl