linux-kernel - RE: [PATCH v7 02/13] PCI: cadence: Split PCIe controller header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <CH2PPF4D26F8E1CE090B54394D1252312FFA231A@CH2PPF4D26F8E1C.namprd07.prod.outlook.com>
Date: Mon, 18 Aug 2025 02:01:32 +0000
From: Manikandan Karunakaran Pillai <mpillai@...ence.com>
To: Bjorn Helgaas <helgaas@...nel.org>,
        "hans.zhang@...tech.com"
	<hans.zhang@...tech.com>
CC: "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "lpieralisi@...nel.org"
	<lpieralisi@...nel.org>,
        "kw@...ux.com" <kw@...ux.com>, "mani@...nel.org"
	<mani@...nel.org>,
        "robh@...nel.org" <robh@...nel.org>,
        "kwilczynski@...nel.org" <kwilczynski@...nel.org>,
        "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "fugang.duan@...tech.com" <fugang.duan@...tech.com>,
        "guoyin.chen@...tech.com" <guoyin.chen@...tech.com>,
        "peter.chen@...tech.com"
	<peter.chen@...tech.com>,
        "cix-kernel-upstream@...tech.com"
	<cix-kernel-upstream@...tech.com>,
        "linux-pci@...r.kernel.org"
	<linux-pci@...r.kernel.org>,
        "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v7 02/13] PCI: cadence: Split PCIe controller header file

Thanks Bjorn for your comments. Will address your comments on patches 1 to patches 7, in the next submission

>-----Original Message-----
>From: Bjorn Helgaas <helgaas@...nel.org>
>Sent: Friday, August 15, 2025 2:47 AM
>To: hans.zhang@...tech.com
>Cc: bhelgaas@...gle.com; lpieralisi@...nel.org; kw@...ux.com;
>mani@...nel.org; robh@...nel.org; kwilczynski@...nel.org;
>krzk+dt@...nel.org; conor+dt@...nel.org; Manikandan Karunakaran Pillai
><mpillai@...ence.com>; fugang.duan@...tech.com;
>guoyin.chen@...tech.com; peter.chen@...tech.com; cix-kernel-
>upstream@...tech.com; linux-pci@...r.kernel.org;
>devicetree@...r.kernel.org; linux-kernel@...r.kernel.org
>Subject: Re: [PATCH v7 02/13] PCI: cadence: Split PCIe controller header file
>
>EXTERNAL MAIL
>
>
>On Wed, Aug 13, 2025 at 12:23:20PM +0800, hans.zhang@...tech.com wrote:
>> From: Manikandan K Pillai <mpillai@...ence.com>
>>
>> Split the Cadence PCIe header file by moving the Legacy(LGA)
>> controller register definitions to a separate header file for
>> support of next generation PCIe controller architecture.
>
>s/Legacy(LGA)/Legacy (LGA)/
>
>Similar for "HPA(High Performance architecture)" elsewhere.
>
>> +++ b/drivers/pci/controller/cadence/pcie-cadence-lga-regs.h
>> @@ -0,0 +1,228 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +// Copyright (c) 2017 Cadence
>> +// Cadence PCIe controller driver.
>> +// Author: Manikandan K Pillai <mpillai@...ence.com>
>
>I'm not trying to be a killjoy, but the only author listed in
>pcie-cadence.h is Cyrille Pitchen, and I don't think simply moving
>these definitions to a separate file really counts as becoming the
>author.  I would at least preserve Cyrille's authorship.
>
>Bjorn