linux-kernel - Re: [PATCH 27/38] mmc: sdhci-st: use modern PM macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5fa9ef87-0184-427b-8d64-aae2715d1663@foss.st.com>
Date: Mon, 18 Aug 2025 10:49:21 +0200
From: Patrice CHOTARD <patrice.chotard@...s.st.com>
To: Jisheng Zhang <jszhang@...nel.org>, Ulf Hansson <ulf.hansson@...aro.org>,
        Aubin Constans <aubin.constans@...rochip.com>,
        Nicolas Ferre
	<nicolas.ferre@...rochip.com>,
        Alexandre Belloni
	<alexandre.belloni@...tlin.com>,
        Claudiu Beznea <claudiu.beznea@...on.dev>,
        Manuel Lauss <manuel.lauss@...il.com>,
        Michał Mirosław
	<mirq-linux@...e.qmqm.pl>,
        Jaehoon Chung <jh80.chung@...sung.com>,
        "Krzysztof
 Kozlowski" <krzk@...nel.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        "Heiko
 Stuebner" <heiko@...ech.de>,
        Russell King <linux@...linux.org.uk>,
        "Chaotian
 Jing" <chaotian.jing@...iatek.com>,
        Matthias Brugger
	<matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>,
        "Shawn Guo" <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        "Pengutronix Kernel Team"
	<kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        Adrian Hunter
	<adrian.hunter@...el.com>,
        Kamal Dasu <kamal.dasu@...adcom.com>, Al Cooper
	<alcooperx@...il.com>,
        "Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@...adcom.com>,
        Florian Fainelli
	<florian.fainelli@...adcom.com>,
        Haibo Chen <haibo.chen@....com>,
        "Michal
 Simek" <michal.simek@....com>,
        Eugen Hristev <eugen.hristev@...aro.org>,
        Vignesh Raghavendra <vigneshr@...com>, Ben Dooks <ben-linux@...ff.org>,
        Viresh Kumar <vireshk@...nel.org>, Orson Zhai <orsonzhai@...il.com>,
        "Baolin
 Wang" <baolin.wang@...ux.alibaba.com>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter
	<jonathanh@...dia.com>, Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec
	<jernej.skrabec@...il.com>,
        Samuel Holland <samuel@...lland.org>,
        "Alexey
 Charkov" <alchark@...il.com>
CC: <linux-mmc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 27/38] mmc: sdhci-st: use modern PM macros



On 8/15/25 03:34, Jisheng Zhang wrote:
> Use the modern PM macros for the suspend and resume functions to be
> automatically dropped by the compiler when CONFIG_PM or
> CONFIG_PM_SLEEP are disabled, without having to use #ifdef guards.
> 
> This has the advantage of always compiling these functions in,
> independently of any Kconfig option. Thanks to that, bugs and other
> regressions are subsequently easier to catch.
> 
> Signed-off-by: Jisheng Zhang <jszhang@...nel.org>
> ---
>  drivers/mmc/host/sdhci-st.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Reviewed-by: Patrice Chotard <patrice.chotard@...s.st.com>

Thanks
Patrice

> 
> diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
> index 9157342ff7a4..bf6685805137 100644
> --- a/drivers/mmc/host/sdhci-st.c
> +++ b/drivers/mmc/host/sdhci-st.c
> @@ -445,7 +445,6 @@ static void sdhci_st_remove(struct platform_device *pdev)
>  	reset_control_assert(rstc);
>  }
>  
> -#ifdef CONFIG_PM_SLEEP
>  static int sdhci_st_suspend(struct device *dev)
>  {
>  	struct sdhci_host *host = dev_get_drvdata(dev);
> @@ -492,9 +491,8 @@ static int sdhci_st_resume(struct device *dev)
>  
>  	return sdhci_resume_host(host);
>  }
> -#endif
>  
> -static SIMPLE_DEV_PM_OPS(sdhci_st_pmops, sdhci_st_suspend, sdhci_st_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(sdhci_st_pmops, sdhci_st_suspend, sdhci_st_resume);
>  
>  static const struct of_device_id st_sdhci_match[] = {
>  	{ .compatible = "st,sdhci" },
> @@ -509,7 +507,7 @@ static struct platform_driver sdhci_st_driver = {
>  	.driver = {
>  		   .name = "sdhci-st",
>  		   .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> -		   .pm = &sdhci_st_pmops,
> +		   .pm = pm_sleep_ptr(&sdhci_st_pmops),
>  		   .of_match_table = st_sdhci_match,
>  		  },
>  };