linux-kernel - Re: [PATCH] virtio-vdpa: simplify the code by removing unnecessary variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <6689b30d-62a9-4c6f-8601-c7b8ccfd4855@vivo.com>
Date: Mon, 18 Aug 2025 09:56:10 +0000
From: 赵西超 <zhao.xichao@...o.com>
To: "mst@...hat.com" <mst@...hat.com>, "jasowang@...hat.com"
	<jasowang@...hat.com>
CC: "xuanzhuo@...ux.alibaba.com" <xuanzhuo@...ux.alibaba.com>,
	"eperezma@...hat.com" <eperezma@...hat.com>, "virtualization@...ts.linux.dev"
	<virtualization@...ts.linux.dev>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] virtio-vdpa: simplify the code by removing unnecessary
 variables

> Hi all,
>
> Apologies for the oversight; this patch contains issues. I will send a 
> v2 version of the patch to correct them.
>
> Best regards,
>
> Xichao Zhao
>
>> The may_reduce_num is used only once and has a redundant conversion to bool.
>> Therefore, remove it.
>>
>> Signed-off-by: Xichao Zhao<zhao.xichao@...o.com>
>> ---
>>   drivers/virtio/virtio_vdpa.c | 5 +----
>>   1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c
>> index 657b07a60788..8f762badec86 100644
>> --- a/drivers/virtio/virtio_vdpa.c
>> +++ b/drivers/virtio/virtio_vdpa.c
>> @@ -142,7 +142,6 @@ virtio_vdpa_setup_vq(struct virtio_device *vdev, unsigned int index,
>>   	/* Assume split virtqueue, switch to packed if necessary */
>>   	struct vdpa_vq_state state = {0};
>>   	u32 align, max_num, min_num = 1;
>> -	bool may_reduce_num = true;
>>   	int err;
>>   
>>   	if (!name)
>> @@ -176,8 +175,6 @@ virtio_vdpa_setup_vq(struct virtio_device *vdev, unsigned int index,
>>   	if (ops->get_vq_num_min)
>>   		min_num = ops->get_vq_num_min(vdpa);
>>   
>> -	may_reduce_num = (max_num == min_num) ? false : true;
>> -
>>   	/* Create the vring */
>>   	align = ops->get_vq_align(vdpa);
>>   
>> @@ -186,7 +183,7 @@ virtio_vdpa_setup_vq(struct virtio_device *vdev, unsigned int index,
>>   	else
>>   		dma_dev = vdpa_get_dma_dev(vdpa);
>>   	vq = vring_create_virtqueue_dma(index, max_num, align, vdev,
>> -					true, may_reduce_num, ctx,
>> +					true, max_num == min_num, ctx,
>>   					notify, callback, name, dma_dev);
>>   	if (!vq) {
>>   		err = -ENOMEM;
>
>