linux-kernel - Re: [PATCH] NFSD: Drop redundant conversion to bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c0f4a8ae5fa3d848d7804454df9366c414e9b06c.camel@kernel.org>
Date: Mon, 18 Aug 2025 07:43:08 -0400
From: Jeff Layton <jlayton@...nel.org>
To: Xichao Zhao <zhao.xichao@...o.com>, chuck.lever@...cle.com
Cc: neil@...wn.name, okorniev@...hat.com, Dai.Ngo@...cle.com,
 tom@...pey.com, 	linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] NFSD: Drop redundant conversion to bool

On Mon, 2025-08-18 at 18:03 +0800, Xichao Zhao wrote:
> The result of integer comparison already evaluates to bool. No need for
> explicit conversion.
> 
> Signed-off-by: Xichao Zhao <zhao.xichao@...o.com>
> ---
>  fs/nfsd/debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfsd/debugfs.c b/fs/nfsd/debugfs.c
> index 84b0c8b559dc..f07d790d56aa 100644
> --- a/fs/nfsd/debugfs.c
> +++ b/fs/nfsd/debugfs.c
> @@ -26,7 +26,7 @@ static int nfsd_dsr_get(void *data, u64 *val)
>  
>  static int nfsd_dsr_set(void *data, u64 val)
>  {
> -	nfsd_disable_splice_read = (val > 0) ? true : false;
> +	nfsd_disable_splice_read = (val > 0);
>  	return 0;
>  }
>  

Sure...

Reviewed-by: Jeff Layton <jlayton@...nel.org>