linux-kernel - Re: [PATCH 2/4] ASoC: qcom: audioreach: add documentation for i2s interface type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f050ccd-0fc1-4fb2-94f5-36ed1f2f4f01@linaro.org>
Date: Mon, 18 Aug 2025 13:56:31 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: srinivas.kandagatla@....qualcomm.com, broonie@...nel.org
Cc: perex@...ex.cz, tiwai@...e.com, srini@...nel.org, lgirdwood@...il.com,
 linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 2/4] ASoC: qcom: audioreach: add documentation for i2s
 interface type

On 18/08/2025 13:28, srinivas.kandagatla@....qualcomm.com wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
> 
> Add documentation of possible values for I2S interface types,
> currently this is only documented for DMA module.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
> ---
>  include/uapi/sound/snd_ar_tokens.h | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/include/uapi/sound/snd_ar_tokens.h b/include/uapi/sound/snd_ar_tokens.h
> index bc0b1bede00c..3aa5f4928a2b 100644
> --- a/include/uapi/sound/snd_ar_tokens.h
> +++ b/include/uapi/sound/snd_ar_tokens.h
> @@ -118,6 +118,12 @@ enum ar_event_types {
>   *						LPAIF_WSA = 2,
>   *						LPAIF_VA = 3,
>   *						LPAIF_AXI = 4
> + * Possible values for MI2S
> + *						I2S_INTF_TYPE_PRIMARY = 0,
> + *						I2S_INTF_TYPE_SECOINDARY = 1,

Typo: SECONDARY

> + *						I2S_INTF_TYPE_TERTINARY = 2,

And TERTIARY?

Although, they come from audioreach.h so, well, eh...

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof