linux-kernel - RE: [PATCH RESEND 1/2] cdx: don't select CONFIG_GENERIC_MSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <BL1PR12MB5333E94CBA4297B21F3621C79D31A@BL1PR12MB5333.namprd12.prod.outlook.com>
Date: Mon, 18 Aug 2025 12:22:22 +0000
From: "Agarwal, Nikhil" <nikhil.agarwal@....com>
To: "Gupta, Nipun" <Nipun.Gupta@....com>, "arnd@...db.de" <arnd@...db.de>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"llvm@...ts.linux.dev" <llvm@...ts.linux.dev>,
	"oe-kbuild-all@...ts.linux.dev" <oe-kbuild-all@...ts.linux.dev>,
	"robin.murphy@....com" <robin.murphy@....com>, "krzk@...nel.org"
	<krzk@...nel.org>, "tglx@...utronix.de" <tglx@...utronix.de>,
	"maz@...nel.org" <maz@...nel.org>, "linux@...ssschuh.net"
	<linux@...ssschuh.net>, "chenqiuji666@...il.com" <chenqiuji666@...il.com>,
	"peterz@...radead.org" <peterz@...radead.org>, "robh@...nel.org"
	<robh@...nel.org>, "Gangurde, Abhijit" <abhijit.gangurde@....com>,
	"nathan@...nel.org" <nathan@...nel.org>, Arnd Bergmann <arnd@...nel.org>
Subject: RE: [PATCH RESEND 1/2] cdx: don't select CONFIG_GENERIC_MSI_IRQ


> -----Original Message-----
> From: Nipun Gupta <nipun.gupta@....com>
> Sent: Monday, August 18, 2025 12:03 PM
> To: arnd@...db.de; gregkh@...uxfoundation.org; Agarwal, Nikhil
> <nikhil.agarwal@....com>
> Cc: linux-kernel@...r.kernel.org; llvm@...ts.linux.dev; oe-kbuild-
> all@...ts.linux.dev; robin.murphy@....com; krzk@...nel.org; tglx@...utronix.de;
> maz@...nel.org; linux@...ssschuh.net; chenqiuji666@...il.com;
> peterz@...radead.org; robh@...nel.org; Gangurde, Abhijit
> <abhijit.gangurde@....com>; nathan@...nel.org; Arnd Bergmann
> <arnd@...nel.org>
> Subject: [PATCH RESEND 1/2] cdx: don't select CONFIG_GENERIC_MSI_IRQ
> 
> From: Arnd Bergmann <arnd@...nel.org>
> 
> x86 does not use CONFIG_GENERIC_MSI_IRQ, and trying to enable it anyway
> results in a build failure:
> 
> In file included from include/linux/ssb/ssb.h:10,
>                  from drivers/ssb/pcihost_wrapper.c:18:
> include/linux/gpio/driver.h:41:33: error: field 'msiinfo' has incomplete type
>    41 |         msi_alloc_info_t        msiinfo;
>       |                                 ^~~~~~~
> In file included from include/linux/kvm_host.h:19,
>                  from arch/x86/events/intel/core.c:17:
> include/linux/msi.h:528:33: error: field 'alloc_info' has incomplete type
>   528 |         msi_alloc_info_t        alloc_info;
> 
> Change the driver to actually build without this symbol and remove the incorrect
> 'select' statements.
> 
> Fixes: e8b18c11731d ("cdx: Fix missing GENERIC_MSI_IRQ on compile test")
> Reviewed-by: Robin Murphy <robin.murphy@....com>
> Signed-off-by: Arnd Bergmann <arnd@...nel.org>
Reviewed-by: Nikhil Agarwal <nikhil.agarwal@....com>