linux-kernel - Re: [PATCH v2] iommu/amd: use str

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2ja2sy7xnwdgjum4e5d4xutqzxh6vkbcidn22uc7hkye4lnnrh@2nwur4tgjtrf>
Date: Mon, 18 Aug 2025 12:52:06 +0000
From: Ankit Soni <Ankit.Soni@....com>
To: Xichao Zhao <zhao.xichao@...o.com>
CC: <joro@...tes.org>, <will@...nel.org>, <christophe.jaillet@...adoo.fr>,
	<suravee.suthikulpanit@....com>, <robin.murphy@....com>,
	<iommu@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] iommu/amd: use str_plural() to simplify the code

On Mon, Aug 18, 2025 at 03:05:56PM +0800, Xichao Zhao wrote:
> Use the string choice helper function str_plural() to simplify the code.
> 
> Signed-off-by: Xichao Zhao <zhao.xichao@...o.com>

Reviewed-by: Ankit Soni <Ankit.Soni@....com>

-Ankit

> ---
>  drivers/iommu/amd/iommu.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
> index eb348c63a8d0..fc11a5dab8ec 100644
> --- a/drivers/iommu/amd/iommu.c
> +++ b/drivers/iommu/amd/iommu.c
> @@ -14,6 +14,7 @@
>  #include <linux/pci-ats.h>
>  #include <linux/bitmap.h>
>  #include <linux/slab.h>
> +#include <linux/string_choices.h>
>  #include <linux/debugfs.h>
>  #include <linux/scatterlist.h>
>  #include <linux/dma-map-ops.h>
> @@ -265,7 +266,7 @@ static inline int get_acpihid_device_id(struct device *dev,
>  		return -EINVAL;
>  	if (fw_bug)
>  		dev_err_once(dev, FW_BUG "No ACPI device matched UID, but %d device%s matched HID.\n",
> -			     hid_count, hid_count > 1 ? "s" : "");
> +			     hid_count, str_plural(hid_count));
>  	if (hid_count > 1)
>  		return -EINVAL;
>  	if (entry)
> -- 
> 2.34.1
>