linux-kernel - Re: [PATCH] Bluetooth: hci_ldisc: Remove redundant 0 value initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17f959be-7270-4cc1-85bf-ec2516b8e3d0@molgen.mpg.de>
Date: Mon, 18 Aug 2025 15:13:35 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Liao Yuanhong <liaoyuanhong@...o.com>
Cc: Marcel Holtmann <marcel@...tmann.org>,
 Luiz Augusto von Dentz <luiz.dentz@...il.com>,
 linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: hci_ldisc: Remove redundant 0 value
 initialization

Dear Liao,


Thank you for the patch.

Am 18.08.25 um 14:36 schrieb Liao Yuanhong:
> The hci_uart struct is already zeroed by kzalloc(). It's redundant to
> initialize hu->padding to 0.
> 
> Signed-off-by: Liao Yuanhong <liaoyuanhong@...o.com>
> ---
>   drivers/bluetooth/hci_ldisc.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c
> index d0adae3267b4..e7a55c2e63f1 100644
> --- a/drivers/bluetooth/hci_ldisc.c
> +++ b/drivers/bluetooth/hci_ldisc.c
> @@ -508,7 +508,6 @@ static int hci_uart_tty_open(struct tty_struct *tty)
>   
>   	/* disable alignment support by default */
>   	hu->alignment = 1;
> -	hu->padding = 0;
>   
>   	/* Use serial port speed as oper_speed */
>   	hu->oper_speed = tty->termios.c_ospeed;

Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>


Kind regards,

Paul