linux-kernel - [EXTERNAL] [PATCH] irqchip/mvebu-gicp: Fix an IS_ERR() vs NULL check in probe()The ioremap() function never returns error pointers, it returns NULLd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID:
 <BN9PR18MB4251D8CDC437668CD774C651DB30A@BN9PR18MB4251.namprd18.prod.outlook.com>
Date: Tue, 19 Aug 2025 12:05:27 +0000
From: Elad Nachman <enachman@...vell.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Andrew Lunn <andrew@...n.ch>,
        Gregory Clement
	<gregory.clement@...tlin.com>,
        Sebastian Hesselbarth
	<sebastian.hesselbarth@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org"
	<kernel-janitors@...r.kernel.org>
Subject: [EXTERNAL] [PATCH] irqchip/mvebu-gicp: Fix an IS_ERR() vs NULL check
 in probe()The ioremap() function never returns error pointers, it returns
 NULLd

Acked-by: Elad Nachman <enachman@...vell.com>

>The ioremap() function never returns error pointers, it returns NULL
>on error.  Fix the checking to match.
>
>Fixes: 3c3d7dbab2c7 ("irqchip/mvebu-gicp: Clear pending interrupts on init")
>Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
>---
> drivers/irqchip/irq-mvebu-gicp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/irqchip/irq-mvebu-gicp.c b/drivers/irqchip/irq-mvebu-gicp.c
>index 54833717f8a7..667bde3c651f 100644
>--- a/drivers/irqchip/irq-mvebu-gicp.c
>+++ b/drivers/irqchip/irq-mvebu-gicp.c
>@@ -238,7 +238,7 @@ static int mvebu_gicp_probe(struct platform_device *pdev)
> 	}
>
> 	base = ioremap(gicp->res->start, resource_size(gicp->res));
>-	if (IS_ERR(base)) {
>+	if (!base) {
> 		dev_err(&pdev->dev, "ioremap() failed. Unable to clear pending interrupts.\n");
> 	} else {
> 		for (i = 0; i < 64; i++)
>-- 
>2.47.2