linux-kernel - Re: [RESEND PATCH v2 3/3] crypto: ccp - Add AMD Seamless Firmware Servicing (SFS) driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202508192016.ZlSGEWUC-lkp@intel.com>
Date: Tue, 19 Aug 2025 20:22:01 +0800
From: kernel test robot <lkp@...el.com>
To: Ashish Kalra <Ashish.Kalra@....com>, tglx@...utronix.de,
	mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com,
	x86@...nel.org, hpa@...or.com, seanjc@...gle.com,
	pbonzini@...hat.com, thomas.lendacky@....com,
	herbert@...dor.apana.org.au
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev, nikunj@....com,
	davem@...emloft.net, aik@....com, ardb@...nel.org,
	michael.roth@....com, Neeraj.Upadhyay@....com,
	linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
	linux-crypto@...r.kernel.org
Subject: Re: [RESEND PATCH v2 3/3] crypto: ccp - Add AMD Seamless Firmware
 Servicing (SFS) driver

Hi Ashish,

kernel test robot noticed the following build warnings:

[auto build test WARNING on next-20250818]
[cannot apply to herbert-cryptodev-2.6/master herbert-crypto-2.6/master tip/x86/core tip/master linus/master tip/auto-latest v6.17-rc2 v6.17-rc1 v6.16 v6.17-rc2]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ashish-Kalra/x86-sev-Add-new-quiet-parameter-to-snp_leak_pages-API/20250819-042220
base:   next-20250818
patch link:    https://lore.kernel.org/r/1f3398c19eab6701566f4044c2c1059114d9bc48.1755548015.git.ashish.kalra%40amd.com
patch subject: [RESEND PATCH v2 3/3] crypto: ccp - Add AMD Seamless Firmware Servicing (SFS) driver
config: x86_64-rhel-9.4-rust (https://download.01.org/0day-ci/archive/20250819/202508192016.ZlSGEWUC-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
rustc: rustc 1.88.0 (6b00bc388 2025-06-23)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250819/202508192016.ZlSGEWUC-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508192016.ZlSGEWUC-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/crypto/ccp/sfs.c:262:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
     262 |         if (!page) {
         |             ^~~~~
   drivers/crypto/ccp/sfs.c:301:9: note: uninitialized use occurs here
     301 |         return ret;
         |                ^~~
   drivers/crypto/ccp/sfs.c:262:2: note: remove the 'if' if its condition is always false
     262 |         if (!page) {
         |         ^~~~~~~~~~~~
     263 |                 dev_dbg(dev, "Command Buffer HV-Fixed page allocation failed\n");
         |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     264 |                 goto cleanup_dev;
         |                 ~~~~~~~~~~~~~~~~~
     265 |         }
         |         ~
   drivers/crypto/ccp/sfs.c:250:9: note: initialize the variable 'ret' to silence this warning
     250 |         int ret;
         |                ^
         |                 = 0
   1 warning generated.


vim +262 drivers/crypto/ccp/sfs.c

   244	
   245	int sfs_dev_init(struct psp_device *psp)
   246	{
   247		struct device *dev = psp->dev;
   248		struct sfs_device *sfs_dev;
   249		struct page *page;
   250		int ret;
   251	
   252		sfs_dev = devm_kzalloc(dev, sizeof(*sfs_dev), GFP_KERNEL);
   253		if (!sfs_dev)
   254			return -ENOMEM;
   255	
   256		/*
   257		 * Pre-allocate 2MB command buffer for all SFS commands using
   258		 * SNP HV_Fixed page allocator which also transitions the
   259		 * SFS command buffer to HV_Fixed page state if SNP is enabled.
   260		 */
   261		page = snp_alloc_hv_fixed_pages(SFS_NUM_2MB_PAGES_CMDBUF);
 > 262		if (!page) {

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki