linux-kernel - Re: [PATCH 1/2] pinctrl: sx150x: Make the driver tristate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdaeAqD=mpG4y16CPKwJ=pjATY9TxeRnXR9abziCOQb-0Q@mail.gmail.com>
Date: Tue, 19 Aug 2025 14:55:59 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Fange Zhang <fange.zhang@....qualcomm.com>
Cc: Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	dmitry.baryshkov@....qualcomm.com, tingwei.zhang@....qualcomm.com, 
	xiangxu.yin@....qualcomm.com
Subject: Re: [PATCH 1/2] pinctrl: sx150x: Make the driver tristate

On Mon, Aug 18, 2025 at 6:41 AM Fange Zhang
<fange.zhang@....qualcomm.com> wrote:

> Set PINCTRL_SX150X config option as a tristate and add
> MODULE_DEVICE_TABLE()/MODULE_LICENSE() to export appropriate information.
>
> Signed-off-by: Fange Zhang <fange.zhang@....qualcomm.com>

Fair enough!

This patch 1/2 applied to the pinctrl tree.

Please funnel patch 2/2 through the SoC tree.

> subsys_initcall(sx150x_init

I seriously wonder about this. It feels like this driver should
be a pure module_init() device. But other users may disagree.

Yours,
Linus Walleij