linux-kernel - Re: [PATCH v3] arm64: dts: rockchip: add USB-C support for ROCK 5B/5B+/5T

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <175560761722.43635.9593798407318901845.robh@kernel.org>
Date: Tue, 19 Aug 2025 08:09:58 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Sebastian Reichel <sebastian.reichel@...labora.com>
Cc: linux-arm-kernel@...ts.infradead.org, 
 linux-rockchip@...ts.infradead.org, Conor Dooley <conor+dt@...nel.org>, 
 linux-kernel@...r.kernel.org, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 devicetree@...r.kernel.org, kernel@...labora.com, 
 Heiko Stuebner <heiko@...ech.de>
Subject: Re: [PATCH v3] arm64: dts: rockchip: add USB-C support for ROCK
 5B/5B+/5T


On Mon, 18 Aug 2025 20:13:44 +0200, Sebastian Reichel wrote:
> Add hardware description for the USB-C port in the Radxa ROCK 5 Model B
> family. This describes the OHCI, EHCI and XHCI USB parts. The DisplayPort
> AltMode is only partially described, as bindings for the necessary
> DisplayPort controller are still being reviewed.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.com>
> ---
> This series adds USB-C support for the ROCK 5B, ROCK 5B+ and ROCK 5T.
> 
> Now that [0] has been merged, this should finally work reasonably
> stable. Note, that there is a regression in 6.17-rc1, which breaks
> stable operation again. I've send a revert of that in [1]. I think
> it's time to enable the USB-C interface, so that we can claim further
> breaks as proper regressions :)
> 
> [0] https://lore.kernel.org/all/20250704-fusb302-race-condition-fix-v1-1-239012c0e27a@kernel.org/
> [1] https://lore.kernel.org/linux-usb/20250818-fusb302-unthreaded-irq-v1-1-3a9a11a9f56f@kernel.org/
> 
> Changes in PATCHv3:
>  - Link to v2: https://lore.kernel.org/r/20250508-rock5bp-for-upstream-v2-0-677033cc1ac2@kernel.org
>  - Rebased to latest for-next branch from Heiko
>    - Dropped merged patches for initial ROCK 5B+ support
>  - Renamed series, since it just adds USB-C support now
>  - Fix pinctrl for Rock 5B SBU DC pins
>  - Also handle ROCK 5T
> 
> Changes in PATCHv2:
>  - Link to v1: https://lore.kernel.org/r/20250324-rock5bp-for-upstream-v1-0-6217edf15b19@kernel.org
>  - Replaced DT binding patch with the version from NAOKI
>  - Dropped unused pinctrl for vcc5v0_host_en from the shared DT
>  - Moved USB-C SBU DC pins to board specific files, since they differ
>    between Rock 5B and Rock 5B+
>  - Added pinmux for SBU DC pins
>  - Rebased to latest version of Heiko's for-next branch
>  - Disable USB-C on Rock 5B for now
> ---
>  .../boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi   | 136 +++++++++++++++++++++
>  .../boot/dts/rockchip/rk3588-rock-5b-plus.dts      |  12 ++
>  arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts    |  12 ++
>  arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts    |  12 ++
>  4 files changed, 172 insertions(+)
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: using specified base-commit 7f0817eee7ba40b48e956955d6fd8ba14750168c

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for 20250818-rock5bp-for-upstream-v3-1-d13f3cdec86c@...nel.org:

arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dtb: pinctrl (rockchip,rk3588-pinctrl): usbc-sbu-dc:rockchip,pins: [[0, 20, 0, 268], [0, 21, 0, 268]] is not of type 'object'
	from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#