linux-kernel - Re: [PATCH] backlight: led_bl: Use devm_kcalloc() for array space allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <61d4c6ab-1326-4c30-81e1-28bc500f8877@vivo.com>
Date: Tue, 19 Aug 2025 21:29:13 +0800
From: Qianfeng Rong <rongqianfeng@...o.com>
To: Daniel Thompson <daniel@...cstar.com>
Cc: Lee Jones <lee@...nel.org>, Daniel Thompson <danielt@...nel.org>,
 Jingoo Han <jingoohan1@...il.com>, Helge Deller <deller@....de>,
 dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] backlight: led_bl: Use devm_kcalloc() for array space
 allocation


在 2025/8/19 21:20, Daniel Thompson 写道:
> [You don't often get email from daniel@...cstar.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> On Tue, Aug 19, 2025 at 11:58:03AM +0800, Qianfeng Rong wrote:
>> Replace calls of devm_kzalloc() with devm_kcalloc() in led_bl_get_leds()
>> and led_bl_parse_levels() for safer memory allocation with built-in
>> overflow protection.
>> Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>
>> ---
> I assume you scanned drivers/video/backlight to look for similar code
> patterns in other backlight drivers? If you did it would have been
> really helpful to say so in this part of the patch (because in it's
> absence I had to do that myself).
Yes, I scanned the entire system and there was only this one in 
drivers/video/backlight.
>
> However, the code changes are fine:
> Reviewed-by: Daniel Thompson (RISCstar) <danielt@...nel.org>
>
Best regards,
Qianfeng