linux-kernel - Re: [PATCH v2 04/24] media: iris: Fix port streaming handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <552c0e8d-f3ae-4c2e-ac8d-f43cde5c5ccb@linaro.org>
Date: Tue, 19 Aug 2025 14:34:33 +0100
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Dikshita Agarwal <quic_dikshita@...cinc.com>,
 Vikash Garodia <quic_vgarodia@...cinc.com>,
 Abhinav Kumar <abhinav.kumar@...ux.dev>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Hans Verkuil
 <hverkuil@...all.nl>, Stefan Schmidt <stefan.schmidt@...aro.org>,
 Vedang Nagar <quic_vnagar@...cinc.com>
Cc: linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org, Renjiang Han <quic_renjiang@...cinc.com>,
 Wangao Wang <quic_wangaow@...cinc.com>
Subject: Re: [PATCH v2 04/24] media: iris: Fix port streaming handling

On 18/08/2025 10:45, Dikshita Agarwal wrote:
> 
> 
> On 8/16/2025 4:10 PM, Bryan O'Donoghue wrote:
>> On 13/08/2025 10:37, Dikshita Agarwal wrote:
>>> +    if (!ret)
>>
>> I think you should have a consistent error pattern
>>
>> if (ret)
>>      goto error;
>>
> Its done to avoid duplication of code, otherwise it would look like
> 
> if (inst->state == IRIS_INST_STREAMING)
> 	ret = iris_queue_internal_deferred_buffers(inst, BUF_DPB);
> 	if (ret)
> 		goto error;
> 	
> 	ret = iris_queue_deferred_buffers(inst, buf_type);
> 	if (ret)
> 		goto error;
> 
> and more duplication when encoder is added.

Understood, IMO the pattern above is clearer and easier to read.

Up to you if you want to change it though.

---
bod