linux-kernel - Re: [PATCH net-next v5] net: avoid one loop iteration in __skb_splice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <willemdebruijn.kernel.1ccfaff4b5510@gmail.com>
Date: Tue, 19 Aug 2025 09:55:16 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Pengtao He <hept.hept.hept@...il.com>, 
 "David S. Miller" <davem@...emloft.net>, 
 Eric Dumazet <edumazet@...gle.com>, 
 Jakub Kicinski <kuba@...nel.org>, 
 Paolo Abeni <pabeni@...hat.com>, 
 Simon Horman <horms@...nel.org>, 
 Willem de Bruijn <willemb@...gle.com>, 
 Mina Almasry <almasrymina@...gle.com>, 
 Jason Xing <kerneljasonxing@...il.com>, 
 Michal Luczaj <mhal@...x.co>, 
 Eric Biggers <ebiggers@...gle.com>, 
 Alexander Lobakin <aleksander.lobakin@...el.com>
Cc: netdev@...r.kernel.org, 
 linux-kernel@...r.kernel.org, 
 Pengtao He <hept.hept.hept@...il.com>
Subject: Re: [PATCH net-next v5] net: avoid one loop iteration in
 __skb_splice_bits

Pengtao He wrote:
> If *len is equal to 0 at the beginning of __splice_segment
> it returns true directly. But when decreasing *len from
> a positive number to 0 in __splice_segment, it returns false.
> The __skb_splice_bits needs to call __splice_segment again.
> 
> Recheck *len if it changes, return true in time.
> Reduce unnecessary calls to __splice_segment.
> 
> Signed-off-by: Pengtao He <hept.hept.hept@...il.com>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>