linux-kernel - Re: [PATCH 6/6] iio: mcp9600: Add support for IIR filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7292e8d-ac7f-43af-b77a-7a1ad8403962@baylibre.com>
Date: Tue, 19 Aug 2025 09:15:23 -0500
From: David Lechner <dlechner@...libre.com>
To: Jonathan Cameron <jic23@...nel.org>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/6] iio: mcp9600: Add support for IIR filter

On 8/19/25 9:11 AM, Ben Collins wrote:
> On Tue, Aug 19, 2025 at 09:05:39AM -0500, David Lechner wrote:
>> On 8/18/25 1:32 PM, Ben Collins wrote:
>>> From: Ben Collins <bcollins@...ter.com>
>>>
>>> MCP9600 supports an IIR filter with 7 levels. Add IIR attribute
>>> to allow get/set of this value.
>>>
>>> Use a filter_type[none, ema] for enabling the IIR filter.
>>>
>>> Signed-off-by: Ben Collins <bcollins@...ter.com>
>>> ---
>>> +		if (data->filter_level == 0)
>>> +			return -EINVAL;
>>
>> To implement Jonathan's request from v5, drop this error return.
>> We'll also need a separate bool data->is_filter_enabled field so
>> that we can keep the last set filter_level even when the filter
>> is disabled. (i.e. data->filter_level is never == 0).
>>
>> This way, if you set the filter level, you can enable and disable
>> the filter via filter_type and still have the same filter level.
>>
> 
> Thanks, David. This is exactly what I've implemented, plus the
> filter_enable attribute.
> 
> Adding the ABI doc updates as well.
> 


Don't add the filter_enable attribute. The filter_type attribute
already does the job.