lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aKSHa8QhidY0ZMAi@google.com>
Date: Tue, 19 Aug 2025 07:17:15 -0700
From: Sean Christopherson <seanjc@...gle.com>
To: Colin Ian King <colin.i.king@...il.com>
Cc: Paolo Bonzini <pbonzini@...hat.com>, Thomas Gleixner <tglx@...utronix.de>, 
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, 
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org, 
	"H . Peter Anvin" <hpa@...or.com>, kvm@...r.kernel.org, kernel-janitors@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] KVM: x86: Remove space before \n newline

On Mon, Jul 21, 2025, Colin Ian King wrote:
> There is a extraneous space before a newline in a pr_debug_ratelimited
> message. Remove it.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>  arch/x86/kvm/vmx/vmx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index aa157fe5b7b3..e5358277d059 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -3142,7 +3142,7 @@ static void enter_lmode(struct kvm_vcpu *vcpu)
>  
>  	guest_tr_ar = vmcs_read32(GUEST_TR_AR_BYTES);
>  	if ((guest_tr_ar & VMX_AR_TYPE_MASK) != VMX_AR_TYPE_BUSY_64_TSS) {
> -		pr_debug_ratelimited("%s: tss fixup for long mode. \n",
> +		pr_debug_ratelimited("%s: tss fixup for long mode.\n",
>  				     __func__);

I'm inclined to simply delete the pr_debug.  I can't imagine it's at all useful
for anyone/anything.

>  		vmcs_write32(GUEST_TR_AR_BYTES,
>  			     (guest_tr_ar & ~VMX_AR_TYPE_MASK)
> -- 
> 2.50.0
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ