linux-kernel - Re: [PATCH] drm/amd/display: Remove redundant header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_P78iHtM=kQQhiY2nf9j_PKnQKSqLNYchG1bcY56jWYvg@mail.gmail.com>
Date: Tue, 19 Aug 2025 10:58:29 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Liao Yuanhong <liaoyuanhong@...o.com>
Cc: Harry Wentland <harry.wentland@....com>, Leo Li <sunpeng.li@....com>, 
	Rodrigo Siqueira <siqueira@...lia.com>, Alex Deucher <alexander.deucher@....com>, 
	Christian König <christian.koenig@....com>, 
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Alex Hung <alex.hung@....com>, 
	Aric Cyr <aric.cyr@....com>, Taimur Hassan <Syed.Hassan@....com>, 
	Aurabindo Pillai <aurabindo.pillai@....com>, Dillon Varone <dillon.varone@....com>, 
	Yihan Zhu <Yihan.Zhu@....com>, Muhammad Ahmed <Muhammad.Ahmed@....com>, 
	George Shen <george.shen@....com>, Reza Amini <reza.amini@....com>, 
	Cruise Hung <Cruise.Hung@....com>, 
	"open list:AMD DISPLAY CORE" <amd-gfx@...ts.freedesktop.org>, 
	"open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/amd/display: Remove redundant header files

Applied.  Thanks!

On Tue, Aug 19, 2025 at 10:33 AM Liao Yuanhong <liaoyuanhong@...o.com> wrote:
>
> The header file "dc_stream.h" is already included on line 1507. Remove the
> redundant include.
>
> This is because the header file was initially included towards the latter
> part of the code. Subsequent commits had to include the header file again
> earlier in the code. In my opinion, this doesn't count as a fix; it just
> requires removing the redundant header inclusion.
>
> Signed-off-by: Liao Yuanhong <liaoyuanhong@...o.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dc.h | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
> index 1ab05eabbddb..2ceaf861edb9 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc.h
> +++ b/drivers/gpu/drm/amd/display/dc/dc.h
> @@ -1854,8 +1854,6 @@ void dc_3dlut_func_retain(struct dc_3dlut *lut);
>  void dc_post_update_surfaces_to_stream(
>                 struct dc *dc);
>
> -#include "dc_stream.h"
> -
>  /**
>   * struct dc_validation_set - Struct to store surface/stream associations for validation
>   */
> --
> 2.34.1
>