[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aKSe_dpuQ35eZaVs@pluto>
Date: Tue, 19 Aug 2025 16:57:49 +0100
From: Cristian Marussi <cristian.marussi@....com>
To: Peng Fan <peng.fan@....com>
Cc: Sudeep Holla <sudeep.holla@....com>,
Cristian Marussi <cristian.marussi@....com>,
Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>, arm-scmi@...r.kernel.org,
imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/6] firmware: arm_scmi: imx: Support discovering
buildinfo of MISC protocol
On Thu, Jul 10, 2025 at 04:33:27PM +0800, Peng Fan wrote:
> MISC protocol supports discovering the System Manager(SM) build
> information including build commit, build time and etc. Retrieve the
> information from SM.
Hi,
>
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
> .../firmware/arm_scmi/vendors/imx/imx-sm-misc.c | 42 ++++++++++++++++++++++
> 1 file changed, 42 insertions(+)
>
> diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> index a8915d3b4df518719d56bfff38922625ad9b70f6..b301f09ab6cc65d286edb8819031d7f4c02e8272 100644
> --- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> +++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> @@ -25,6 +25,7 @@
> enum scmi_imx_misc_protocol_cmd {
> SCMI_IMX_MISC_CTRL_SET = 0x3,
> SCMI_IMX_MISC_CTRL_GET = 0x4,
> + SCMI_IMX_MISC_DISCOVER_BUILDINFO = 0x6,
> SCMI_IMX_MISC_CTRL_NOTIFY = 0x8,
> };
>
> @@ -65,6 +66,15 @@ struct scmi_imx_misc_ctrl_get_out {
> __le32 val[];
> };
>
> +struct scmi_imx_misc_buildinfo_out {
> + __le32 buildnum;
> + __le32 buildcommit;
> +#define MISC_MAX_BUILDDATE 16
> + u8 builddate[MISC_MAX_BUILDDATE];
> +#define MISC_MAX_BUILDTIME 16
> + u8 buildtime[MISC_MAX_BUILDTIME];
> +};
> +
> static int scmi_imx_misc_attributes_get(const struct scmi_protocol_handle *ph,
> struct scmi_imx_misc_info *mi)
> {
> @@ -272,6 +282,34 @@ static int scmi_imx_misc_ctrl_set(const struct scmi_protocol_handle *ph,
> return ret;
> }
>
> +static int scmi_imx_misc_discover_build_info(const struct scmi_protocol_handle *ph)
> +{
> + struct scmi_imx_misc_buildinfo_out *out;
> + char date[MISC_MAX_BUILDDATE] = {'\0'};
> + char time[MISC_MAX_BUILDTIME] = {'\0'};
...dont think that these 2 array needs to be NULL terminated given that
they are used as the dest buffer for strscpy() which always terminates
the dest buffer returning always a valid string.
> + struct scmi_xfer *t;
> + int ret;
> +
> + ret = ph->xops->xfer_get_init(ph, SCMI_IMX_MISC_DISCOVER_BUILDINFO, 0,
> + sizeof(*out), &t);
> + if (ret)
> + return ret;
> +
> + ret = ph->xops->do_xfer(ph, t);
> + if (!ret) {
> + out = t->rx.buf;
> + strscpy(date, out->builddate, MISC_MAX_BUILDDATE);
> + strscpy(time, out->buildtime, MISC_MAX_BUILDTIME);
> + dev_info(ph->dev, "SM Version\t= Build %u, Commit %08x %s %s\n",
> + le32_to_cpu(out->buildnum), le32_to_cpu(out->buildcommit),
> + date, time);
> + }
> +
...other than this...LGTM.
Reviewed-by: Cristian Marussi <cristian.marussi@....com>
Thanks,
Cristian
Powered by blists - more mailing lists