linux-kernel - Re: [PATCH] drm/amd/display: fix leak of probed modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bbur73jxf7kubbtgdieflkjw5q4rxw5w4ztkgrozq3i4mrdjxh@r352gbxsso3s>
Date: Tue, 19 Aug 2025 19:45:04 +0300
From: Fedor Pchelkin <pchelkin@...ras.ru>
To: "Limonciello, Mario" <Mario.Limonciello@....com>
Cc: "Deucher, Alexander" <Alexander.Deucher@....com>, 
	Melissa Wen <mwen@...lia.com>, "Wentland, Harry" <Harry.Wentland@....com>, 
	Rodrigo Siqueira <siqueira@...lia.com>, "Koenig, Christian" <Christian.Koenig@....com>, 
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	Hans de Goede <hansg@...nel.org>, "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>, 
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"lvc-project@...uxtesting.org" <lvc-project@...uxtesting.org>, "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH] drm/amd/display: fix leak of probed modes

On Mon, 18. Aug 21:17, Limonciello, Mario wrote:
> On 8/17/25 4:43 AM, Fedor Pchelkin wrote:
> > For what the patch does there exists a drm_mode_remove() helper but it's
> > static at drivers/gpu/drm/drm_connector.c and requires to be exported
> > first. This probably looks like a subject for an independent for-next
> > patch, if needed.
> 
> So you're saying this change will take two iterations of patches to ping 
> pong the code?
> 
> Why not just send this as a two patch series?
> 
> 1) Export the symbol drm_mode_remove()
> 2) This patch, but use the symbol.
> 

Initially I wasn't sure if the exporting patch was worth moving the code
around and in the end decided to make the current patch with a minimum of
prerequisites.

But giving this a second glance, I see exporting the symbol would be
technically better. I'll send out v2.

Thanks!