linux-kernel - Re: [PATCH v2 5/5] rust: maple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DC6LHHC2RQAE.1D7LOPCF3IZNB@kernel.org>
Date: Tue, 19 Aug 2025 19:53:44 +0200
From: "Danilo Krummrich" <dakr@...nel.org>
To: "Liam R. Howlett" <Liam.Howlett@...cle.com>
Cc: "Alice Ryhl" <aliceryhl@...gle.com>, "Andrew Morton"
 <akpm@...ux-foundation.org>, "Lorenzo Stoakes"
 <lorenzo.stoakes@...cle.com>, "Miguel Ojeda" <ojeda@...nel.org>, "Andrew
 Ballance" <andrewjballance@...il.com>, "Boqun Feng" <boqun.feng@...il.com>,
 "Gary Guo" <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, "Benno Lossin" <lossin@...nel.org>, "Andreas
 Hindborg" <a.hindborg@...nel.org>, "Trevor Gross" <tmgross@...ch.edu>,
 <linux-kernel@...r.kernel.org>, <maple-tree@...ts.infradead.org>,
 <rust-for-linux@...r.kernel.org>, <linux-mm@...ck.org>
Subject: Re: [PATCH v2 5/5] rust: maple_tree: add MAINTAINERS entry

On Tue Aug 19, 2025 at 3:36 PM CEST, Liam R. Howlett wrote:
> * Danilo Krummrich <dakr@...nel.org> [250819 07:49]:
>> On Tue Aug 19, 2025 at 12:34 PM CEST, Alice Ryhl wrote:
>> > Similar to and just below the existing MAPLE TREE entry.
>> >
>> > Signed-off-by: Alice Ryhl <aliceryhl@...gle.com>
>> > ---
>> > Liam: I'm not sure what you prefer for the MAINTAINERS entry, so let me
>> > know if you want anything changed. There are also a few other options,
>> > for example, I could just add the files under the existing MAPLE TREE
>> > entry? The get_maintainers script should still send any relevant patches
>> > my way because they also match the RUST entry that has a wildcard on the
>> > rust/ directory.
>> 
>> From v1 [1]:
>> 
>> 	>> We should have another section for the maple tree, since it's not just
>> 	>> used for mm.  Your stated plan is to use it for GPU allocations and the
>> 	>> code doesn't live in mm/, wdyt?
>> 	
>> 	> Sure, I can add a new section if you prefer that.
>> 
>> Maple tree is already used outside of mm, e.g. for regmap stuff and I also use
>> it in nouveau. Hence, I read this as moving maple tree to e.g. lib/ adjusting
>> the existing entry.
>> 
>> I personally think that - of course unless the affected people prefer otherwise
>> - it is usually best to keep a single maintainers entry for the C and the Rust
>> code. Maybe Alice can simply be added to the existing maintainers entry?
>> 
>> What do you think?
>
> I'm not sure what you mean by lib/ since the lib files are spread into
> other entries by the looks of it?

I think I misunderstood your comment from [1] above, and, despite knowing
better, mistakenly assumed otherwise -- just ignore this comment.

> I'm okay with the entry below or adjusting the existing one.

If you're both fine with either, I suggest to keep a single entry for both.

In general I think it's better if we try to avoid to differentiate between Rust
and C code of a single subsystem (or component) maintenance wise unless there
are specific reasons.

Even though sometimes it's just a formality, I think it can help to bring people
together and learn from each other. There more good examples we can set up for
this, the better. :)

>> [1] https://lore.kernel.org/all/aJW3L3SEVUl_AVvN@google.com/