linux-kernel - Re: [PATCH 1/1] dt-bindings: iio: adc: max1238: Add #io-channel-cells property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250819-astronomy-gladiator-21823768723a@spud>
Date: Tue, 19 Aug 2025 19:12:10 +0100
From: Conor Dooley <conor@...nel.org>
To: Frank Li <Frank.Li@....com>
Cc: Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@...r.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>, imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: iio: adc: max1238: Add
 #io-channel-cells property

On Mon, Aug 18, 2025 at 04:00:13PM -0400, Frank Li wrote:
> Add #io-channel-cells property because it is multi-channel ADC.

As far as I understand it, that's not a correct statement. A single
channel ADC can have the property, but it would be set to 0 just as a
single clock provider has #clock-cells of 0.

I did check the devices and they do all appear to be multichannel (not
just the 1238) so the change you're making here looks correct, unless
some of them would actually require 2 cells for some reason - but you
should really state that in your commit message when there's about 30
compatibles so that I don't have to check them.

With an accurate commit message,
Acked-by: Conor Dooley <conor.dooley@...rochip.com>
Maybe Jonathan is willing to do that since it's just adding "of 1" to
the first sentence.

> 
> Fix below CHECK_DTBS warnings:
>   arch/arm/boot/dts/nxp/ls/ls1021a-iot.dtb: adc@35 (maxim,max1239): '#io-channel-cells' does not match any of the regexes: '^pinctrl-[0-9]+$'
> 	from schema $id: http://devicetree.org/schemas/iio/adc/maxim,max1238.yaml#
> 
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
>  Documentation/devicetree/bindings/iio/adc/maxim,max1238.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/maxim,max1238.yaml b/Documentation/devicetree/bindings/iio/adc/maxim,max1238.yaml
> index 60d7b34e3286f..ae3c89393f1a3 100644
> --- a/Documentation/devicetree/bindings/iio/adc/maxim,max1238.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/maxim,max1238.yaml
> @@ -53,6 +53,9 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  "#io-channel-cells":
> +    const: 1
> +
>    vcc-supply: true
>    vref-supply:
>      description: Optional external reference.  If not supplied, internal
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)