linux-kernel - Re: [PATCH v7 1/2] scsi: sd: Fix build warning in sd_revalidate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <240eec29-860d-437c-8e46-9c7af3e4a0fc@acm.org>
Date: Tue, 19 Aug 2025 12:26:23 -0700
From: Bart Van Assche <bvanassche@....org>
To: Abinash Singh <abinashsinghlalotra@...il.com>,
 "James E . J . Bottomley" <James.Bottomley@...senPartnership.com>,
 "Martin K . Petersen" <martin.petersen@...cle.com>
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 1/2] scsi: sd: Fix build warning in
 sd_revalidate_disk()

On 8/16/25 1:53 PM, Abinash Singh wrote:
> +	kfree(lim);
> +	kfree(buffer);

The traditional order for kfree() statements is the opposite order of
the corresponding kmalloc() calls. With or without this change:

Reviewed-by: Bart Van Assche <bvanassche@....org>