linux-kernel - Re: [PATCH V7 1/3] x86/tdx: Eliminate duplicate code in tdx_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGtprH9PdJDzZb=YwOSpFjgNjn0W2K6KFsJNwuEgCSBZ=9f3vQ@mail.gmail.com>
Date: Tue, 19 Aug 2025 12:52:03 -0700
From: Vishal Annapurve <vannapurve@...gle.com>
To: Adrian Hunter <adrian.hunter@...el.com>
Cc: Dave Hansen <dave.hansen@...ux.intel.com>, pbonzini@...hat.com, seanjc@...gle.com, 
	Tony Luck <tony.luck@...el.com>, Borislav Petkov <bp@...en8.de>, Thomas Gleixner <tglx@...utronix.de>, 
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org, H Peter Anvin <hpa@...or.com>, 
	linux-kernel@...r.kernel.org, kvm@...r.kernel.org, rick.p.edgecombe@...el.com, 
	kas@...nel.org, kai.huang@...el.com, reinette.chatre@...el.com, 
	xiaoyao.li@...el.com, tony.lindgren@...ux.intel.com, 
	binbin.wu@...ux.intel.com, isaku.yamahata@...el.com, yan.y.zhao@...el.com, 
	chao.gao@...el.com
Subject: Re: [PATCH V7 1/3] x86/tdx: Eliminate duplicate code in tdx_clear_page()

On Tue, Aug 19, 2025 at 8:58 AM Adrian Hunter <adrian.hunter@...el.com> wrote:
>
> tdx_clear_page() and reset_tdx_pages() duplicate the TDX page clearing
> logic.  Rename reset_tdx_pages() to tdx_quirk_reset_paddr() and create
> tdx_quirk_reset_page() to call tdx_quirk_reset_paddr() and be used in
> place of tdx_clear_page().
>
> The new name reflects that, in fact, the clearing is necessary only for
> hardware with a certain quirk.  That is dealt with in a subsequent patch
> but doing the rename here avoids additional churn.
>
> Note reset_tdx_pages() is slightly different from tdx_clear_page() because,
> more appropriately, it uses mb() in place of __mb().  Except when extra
> debugging is enabled (kcsan at present), mb() just calls __mb().
>
> Reviewed-by: Kirill A. Shutemov <kas@...nel.org>
> Reviewed-by: Binbin Wu <binbin.wu@...ux.intel.com>
> Reviewed-by: Xiaoyao Li <xiaoyao.li@...el.com>
> Acked-by: Kai Huang <kai.huang@...el.com>
> Acked-by: Sean Christopherson <seanjc@...gle.com>
> Reviewed-by: Rick Edgecombe <rick.p.edgecombe@...el.com>
> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>

Acked-by: Vishal Annapurve <vannapurve@...gle.com>