linux-kernel - Re: [PATCH v3 1/6] dt-bindings: mfd: twl: Add missing sub-nodes for TWL4030 & TWL603x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250819223157.0b271c74@akair>
Date: Tue, 19 Aug 2025 22:31:57 +0200
From: Andreas Kemnade <andreas@...nade.info>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Jihed Chaibi <jihed.chaibi.dev@...il.com>, linux-kernel@...r.kernel.org,
 peter.ujfalusi@...il.com, dmitry.torokhov@...il.com, robh@...nel.org,
 krzk+dt@...nel.org, lgirdwood@...il.com, tiwai@...e.com,
 conor+dt@...nel.org, lee@...nel.org, ukleinek@...nel.org,
 broonie@...nel.org, gregkh@...uxfoundation.org, linus.walleij@...aro.org,
 brgl@...ev.pl, aaro.koskinen@....fi, khilman@...libre.com,
 rogerq@...nel.org, tony@...mide.com, linux-gpio@...r.kernel.org,
 linux-input@...r.kernel.org, devicetree@...r.kernel.org,
 linux-pwm@...r.kernel.org, linux-sound@...r.kernel.org,
 linux-usb@...r.kernel.org, linux-omap@...r.kernel.org, shuah@...nel.org
Subject: Re: [PATCH v3 1/6] dt-bindings: mfd: twl: Add missing sub-nodes for
 TWL4030 & TWL603x

Am Tue, 19 Aug 2025 10:13:39 +0200
schrieb Krzysztof Kozlowski <krzk@...nel.org>:

> On Sat, Aug 16, 2025 at 04:15:18AM +0200, Jihed Chaibi wrote:
> > Update the TI TWL family Device Tree binding to include additional
> > subnodes for TWL4030, TWL6030, and TWL6032 devices.
> > 
> > The simple power and PWM bindings (ti,twl4030-power, ti,twl-pwm, and
> > ti,twl-pwmled) are now defined directly within this binding.
> > 
> > Other child node definitions (audio, gpio, keypad, usb, etc.) are also
> > added to the schema. These additions fix 'unevaluated properties'
> > errors found during dtbs_check for boards like the omap3-beagle
> > and improve the binding's overall completeness.
> > 
> > Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@...il.com>
> > 
> > ---
> > Changes in v3:
> >  - New patch to consolidate simple bindings (power, pwm) and add
> >    definitions for all child nodes to fix dtbs_check validation
> >    errors found in v2.
> > ---
> >  .../devicetree/bindings/mfd/ti,twl.yaml       | 191 ++++++++++++++++++
> >  .../devicetree/bindings/mfd/twl4030-power.txt |  48 -----
> >  .../devicetree/bindings/pwm/ti,twl-pwm.txt    |  17 --
> >  .../devicetree/bindings/pwm/ti,twl-pwmled.txt |  17 --
> >  4 files changed, 191 insertions(+), 82 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/mfd/twl4030-power.txt
> >  delete mode 100644 Documentation/devicetree/bindings/pwm/ti,twl-pwm.txt
> >  delete mode 100644 Documentation/devicetree/bindings/pwm/ti,twl-pwmled.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/ti,twl.yaml b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> > index f162ab60c..b0f1cb7b5 100644
> > --- a/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> > @@ -76,6 +76,98 @@ allOf:
> >            properties:
> >              compatible:
> >                const: ti,twl4030-wdt
> > +
> > +        audio:
> > +          type: object
> > +          $ref: /schemas/sound/ti,twl4030-audio.yaml#
> > +          unevaluatedProperties: false
> > +
> > +        keypad:
> > +          type: object
> > +          $ref: /schemas/input/ti,twl4030-keypad.yaml#
> > +          unevaluatedProperties: false
> > +
> > +        pwm:
> > +          type: object
> > +          $ref: /schemas/pwm/pwm.yaml#
> > +          unevaluatedProperties: false
> > +          description: |
> > +            TWL4030 series: PWMA and PWMB (connected to LEDA and LEDB terminals)
> > +          properties:
> > +            compatible:
> > +              enum:
> > +                - ti,twl4030-pwm
> > +            '#pwm-cells':
> > +              const: 2
> > +          required:
> > +            - compatible
> > +            - '#pwm-cells'
> > +
> > +        pwmled:
> > +          type: object
> > +          $ref: /schemas/pwm/pwm.yaml#
> > +          unevaluatedProperties: false
> > +          description: |
> > +            TWL4030 series: PWMA and PWMB (connected to LEDA and LEDB terminals)
> > +          properties:
> > +            compatible:
> > +              enum:
> > +                - ti,twl4030-pwmled
> > +            '#pwm-cells':
> > +              const: 2
> > +          required:
> > +            - compatible
> > +            - '#pwm-cells'
> > +
> > +        'twl4030-usb':  
> 
> No need for quotes.
> 
> > +          type: object
> > +          $ref: /schemas/usb/ti,twlxxxx-usb.yaml#  
> 
> Are you sure your patchset is bsiectable? Apply this patch and test. You
> will see errors and you must fix these. Even after fixing you have
> strict dependencies so your cover letter must explain these (or merging
> constraints)...
> 
what are the rules here regarding bisectability? non-existing files
in $ref are probably bad. Are then unveiled errors in dts also a
problem? I would not expect too much fixing effort needed here. I have
not run dtbs_check yet.

I have expected this would all go via Lee's usual immutable branches. 

Regards,
Andreas