[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <175563623228.1286028.14650660035550911275.robh@kernel.org>
Date: Tue, 19 Aug 2025 15:43:52 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Wei Fang <wei.fang@....com>
Cc: shawnguo@...nel.org, kernel@...gutronix.de, vadim.fedorenko@...ux.dev,
linux-kernel@...r.kernel.org, richardcochran@...il.com,
s.hauer@...gutronix.de, edumazet@...gle.com, conor+dt@...nel.org,
claudiu.manoil@....com, vladimir.oltean@....com,
davem@...emloft.net, pabeni@...hat.com, andrew+netdev@...n.ch,
festevam@...il.com, fushi.peng@....com, xiaoning.wang@....com,
imx@...ts.linux.dev, krzk+dt@...nel.org, Frank.Li@....com,
devicetree@...r.kernel.org, netdev@...r.kernel.org, kuba@...nel.org
Subject: Re: [PATCH v4 net-next 02/15] dt-bindings: net: move ptp-timer
property to ethernet-controller.yaml
On Tue, 19 Aug 2025 20:36:07 +0800, Wei Fang wrote:
> For some Ethernet controllers, the PTP timer function is not integrated.
> Instead, the PTP timer is a separate device and provides PTP Hardware
> Clock (PHC) to the Ethernet controller to use, such as NXP FMan MAC,
> ENETC, etc. Therefore, a property is needed to indicate this hardware
> relationship between the Ethernet controller and the PTP timer.
>
> Since this use case is also very common, it is better to add a generic
> property to ethernet-controller.yaml. According to the existing binding
> docs, there are two good candidates, one is the "ptp-timer" defined in
> fsl,fman-dtsec.yaml, and the other is the "ptimer-handle" defined in
> fsl,fman.yaml. From the perspective of the name, the former is more
> straightforward, so move the "ptp-timer" from fsl,fman-dtsec.yaml to
> ethernet-controller.yaml.
>
> Signed-off-by: Wei Fang <wei.fang@....com>
> Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>
> Reviewed-by: Frank Li <Frank.Li@....com>
>
> ---
> v3 changes:
> New patch, add a generic property instead of adding a property to
> fsl,enetc.yaml
> v4 changes:
> 1. Change the title
> 2. Remove "ptp-timer" from fsl,fman-dtsec.yaml
> ---
> .../devicetree/bindings/net/ethernet-controller.yaml | 5 +++++
> Documentation/devicetree/bindings/net/fsl,fman-dtsec.yaml | 4 ----
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
Powered by blists - more mailing lists