linux-kernel - Re: [PATCH] KVM: selftests: Fix signedness issue with vCPU mmap size check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <175564466673.3066105.7016376973027336397.b4-ty@google.com>
Date: Tue, 19 Aug 2025 16:12:13 -0700
From: Sean Christopherson <seanjc@...gle.com>
To: Sean Christopherson <seanjc@...gle.com>, Paolo Bonzini <pbonzini@...hat.com>, 
	James Houghton <jthoughton@...gle.com>
Cc: Venkatesh Srinivas <venkateshs@...gle.com>, kvm@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: selftests: Fix signedness issue with vCPU mmap size check

On Fri, 11 Jul 2025 00:17:42 +0000, James Houghton wrote:
> Check that the return value of KVM_GET_VCPU_MMAP_SIZE is non-negative
> before comparing with sizeof(vcpu_run). If KVM_GET_VCPU_MMAP_SIZE fails,
> it will return -1, and `-1 > sizeof(vcpu_run)` is true, so the ASSERT
> passes.
> 
> There are no other locations in tools/testing/selftests/kvm that make
> the same mistake.
> 
> [...]

Applied to kvm-x86 selftests, thanks!

[1/1] KVM: selftests: Fix signedness issue with vCPU mmap size check
      https://github.com/kvm-x86/linux/commit/a585b8761451

--
https://github.com/kvm-x86/linux/tree/next