linux-kernel - Re: linux-next: Fixes tag needs some work in the mm-unstable tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250819053926.38696-1-sj@kernel.org>
Date: Mon, 18 Aug 2025 22:39:26 -0700
From: SeongJae Park <sj@...nel.org>
To: Sang-Heon Jeon <ekffu200098@...il.com>
Cc: SeongJae Park <sj@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the mm-unstable tree

On Tue, 19 Aug 2025 10:55:13 +0900 Sang-Heon Jeon <ekffu200098@...il.com> wrote:

> On Tue, Aug 19, 2025 at 10:14 AM Andrew Morton
> <akpm@...ux-foundation.org> wrote:
> >
> > On Tue, 19 Aug 2025 09:59:20 +0900 Sang-Heon Jeon <ekffu200098@...il.com> wrote:
> >
> > > > has these problem(s):
> > > >
> > > >   - Target SHA1 does not exist
> > > >
> > > > Maybe you meant
> > > >
> > > > Fixes: a0b60d083fb6 ("selftests/damon: test no-op commit broke DAMON status")
> > >
> > > You're right. I think it might be changed at the point rc1 -> rc2 on
> > > the mm tree.
> > > Is there anything I can do? Or maybe Andrew can help?
> > >
> > > I didn't mean to bother you guys.  Also, original patch is from here [1]
> > >
> > > [1] https://lore.kernel.org/all/20250816014033.190451-1-ekffu200098@gmail.com/
> >
> > I deleted the Fixes: tag.  The quilt filename
> > selftests-damon-test-no-op-commit-broke-damon-status-fix.patch means
> > "this will be folded into
> > selftests-damon-test-no-op-commit-broke-damon-status.patch"
> 
> Thank you, andrew

Thank you for Cc-ing me, Sang-Heon.  Thank you for fixing this, Andrew.

I actually suggested Sang-Heon to add the Fixes: tag, to help Andrew easily
understand the context.  It didn't make noises before, but everything changes.
Anyway I'm also responsible for this noise, sorry about that.

Another common way to send followup fixes for commits in mm tree is, sending
the fixup patches as a reply to the broken patch mail thread, with a brief
explanation of the context for Andrew, like my recent one[1].  I think using
this way without Fixes: tag in the patch can still help Andrew easily
understand the context while not making noises.  Sang-Heon, please consider
using that way if you get similar cases in future.

[1] https://lore.kernel.org/20250709182843.35812-1-sj@kernel.org/

Thanks,
SJ

[...]